mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 10:20:58 -06:00
8cf4ed5f88
This commit introduces a hidden `s3_inventory_bucket` site setting which replaces the `enable_s3_inventory` and `s3_configure_inventory_policy` site setting. The reason `enable_s3_inventory` and `s3_configure_inventory_policy` site settings are removed is because this feature has technically been broken since it was introduced. When the `enable_s3_inventory` feature is turned on, the app will because configure a daily inventory policy for the `s3_upload_bucket` bucket and store the inventories under a prefix in the bucket. The problem here is that once the inventories are created, there is nothing cleaning up all these inventories so whoever that has enabled this feature would have been paying the cost of storing a whole bunch of inventory files which are never used. Given that we have not received any complains about inventory files inflating S3 storage costs, we think that it is very likely that this feature is no longer being used and we are looking to drop support for this feature in the not too distance future. For now, we will still support a hidden `s3_inventory_bucket` site setting which site administrators can configure via the `DISCOURSE_S3_INVENTORY_BUCKET` env.
24 lines
638 B
Ruby
24 lines
638 B
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Jobs::EnsureS3UploadsExistence do
|
|
subject(:job) { described_class.new }
|
|
|
|
context "when `s3_inventory_bucket` has been set" do
|
|
before { SiteSetting.s3_inventory_bucket = "some-bucket-name" }
|
|
|
|
it "works" do
|
|
S3Inventory.any_instance.expects(:backfill_etags_and_list_missing).once
|
|
job.execute({})
|
|
end
|
|
end
|
|
|
|
context "when `s3_inventory_bucket` has not been set" do
|
|
before { SiteSetting.s3_inventory_bucket = nil }
|
|
|
|
it "doesn't execute" do
|
|
S3Inventory.any_instance.expects(:backfill_etags_and_list_missing).never
|
|
job.execute({})
|
|
end
|
|
end
|
|
end
|