mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 09:26:54 -06:00
30990006a9
This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging
39 lines
927 B
Ruby
39 lines
927 B
Ruby
# frozen_string_literal: true
|
|
|
|
class StringSettingValidator
|
|
|
|
include RegexSettingValidation
|
|
|
|
def initialize(opts = {})
|
|
@opts = opts
|
|
initialize_regex_opts(opts)
|
|
end
|
|
|
|
def valid_value?(val)
|
|
return true if !val.present?
|
|
|
|
if (@opts[:min] && @opts[:min].to_i > (val.length)) || (@opts[:max] && @opts[:max].to_i < (val.length))
|
|
@length_fail = true
|
|
return false
|
|
end
|
|
|
|
regex_match?(val)
|
|
end
|
|
|
|
def error_message
|
|
if @regex_fail
|
|
I18n.t(@regex_error)
|
|
elsif @length_fail
|
|
if @opts[:min] && @opts[:max]
|
|
I18n.t('site_settings.errors.invalid_string_min_max', min: @opts[:min], max: @opts[:max])
|
|
elsif @opts[:min]
|
|
I18n.t('site_settings.errors.invalid_string_min', min: @opts[:min])
|
|
else
|
|
I18n.t('site_settings.errors.invalid_string_max', max: @opts[:max])
|
|
end
|
|
else
|
|
I18n.t('site_settings.errors.invalid_string')
|
|
end
|
|
end
|
|
end
|