mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 04:59:22 -06:00
c21df2286c
What problem I am trying to solve? When an encrypted message is crafted and the image is added - discourse needs a hard refresh to display that image. What is happening? Everything starts here - when the upload is finished we add serialized object to the cache https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/components/composer-editor.js#L748:L757 Then, `discourse-encrypt` is trying to get an image from the cache and use `short_path` property https://github.com/discourse/discourse-encrypt/blob/master/assets/javascripts/discourse/initializers/hook-decrypt-post.js.es6#L142:L143 Why is it working after a hard refresh? After refresh, we populate cache once again using that function: https://github.com/discourse/discourse/blob/master/app/assets/javascripts/pretty-text/upload-short-url.js#L11:L17 And lookup_urls method from backend is returning `short_path` https://github.com/discourse/discourse/blob/master/app/controllers/uploads_controller.rb#L55:L64 TL;DR We should expose short path in upload serializer. I ensured that this serializer is used only when attachments are uploaded so it should not affect performance. |
||
|---|---|---|
| .. | ||
| admin_plugin_serializer_spec.rb | ||
| admin_user_list_serializer_spec.rb | ||
| basic_group_serializer_spec.rb | ||
| basic_group_user_serializer_spec.rb | ||
| basic_post_serializer_spec.rb | ||
| basic_user_serializer_spec.rb | ||
| category_detailed_serializer_spec.rb | ||
| category_serializer_spec.rb | ||
| category_upload_serializer_spec.rb | ||
| current_user_serializer_spec.rb | ||
| group_show_serializer_spec.rb | ||
| new_post_result_serializer_spec.rb | ||
| notification_serializer_spec.rb | ||
| post_revision_serializer_spec.rb | ||
| post_serializer_spec.rb | ||
| reviewable_flagged_post_serializer_spec.rb | ||
| reviewable_queued_post_serializer_spec.rb | ||
| reviewable_serializer_spec.rb | ||
| reviewable_user_serializer_spec.rb | ||
| single_sign_on_record_serializer_spec.rb | ||
| site_serializer_spec.rb | ||
| suggested_topic_serializer_spec.rb | ||
| tag_group_serializer_spec.rb | ||
| theme_serializer_spec.rb | ||
| topic_link_serializer_spec.rb | ||
| topic_list_item_serializer_spec.rb | ||
| topic_list_serializer_spec.rb | ||
| topic_view_posts_serializer_spec.rb | ||
| topic_view_serializer_spec.rb | ||
| upload_serializer_spec.rb | ||
| user_auth_token_serializer_spec.rb | ||
| user_bookmark_serializer_spec.rb | ||
| user_serializer_spec.rb | ||
| user_summary_serializer_spec.rb | ||
| web_hook_post_serializer_spec.rb | ||
| web_hook_topic_view_serializer_spec.rb | ||
| web_hook_user_serializer_spec.rb | ||