Commit Graph
46 Commits
Author SHA1 Message Date
Luca Di Maio 2201de4e97 all: add Lilipod container manager support
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2023-09-15 10:58:15 +02:00
Luca Di Maio 46b3aa8e65 init/create: setup user password for rootful containers
This commit will create a first `enter` setup for container user, in
case of rootful containers. The default behavious of passwordless
sudo/su is acceptable for rootless containers, where there is no real
privilege escalation, but is a real concern for rootful containers.

This setup will also respect host's sudoers configuration.

Root account will be locked by default in this modality.

During creation there is a really long and difficult flag that will
rever to the old behaviour, **this is highly discouraged!**

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2023-08-07 01:37:40 +02:00
Luca Di Maio cb4ad1de48 init: fix tzdata/zoneinfo problems and potential incompatibilities for the future. Add test for upgrades. Fix #820, Fix #874
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2023-08-04 16:55:17 +02:00
Luca Di Maio 1e2e791d02 CI: improve listing of containers
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2023-06-12 00:01:08 +02:00
Luca Di Maio 17e1426dbf CI: add website files to codespell ignore list
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2023-06-10 16:05:21 +02:00
Luca Di Maio 1ea46bf35b CI: add codespell action
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2023-04-06 23:23:58 +02:00
Jan Macku 1545051851 ci: trigger differential-shellcheck workflow on push (#681)
Fixes: redhat-plumbers-in-action/differential-shellcheck#215
2023-04-06 22:27:39 +02:00
MikeAlexander, Michael <michael.alexander@karlstorz.com>Luca Di Maio
039c4adae5 init: add init and pre-init hook defaults as supported config options (#542)
* Add init and pre-init hook defaults as supported config options.
* Add config variables to example snippet in README.
* Allow just the name of the pre-init hook script as the option without the --pre-init-hook prefix.
* Fix a typo in the bashate CONTRIBUTING guide.
* CI: update to checkout@v3

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Co-authored-by: Alexander, Michael <michael.alexander@karlstorz.com>
Co-authored-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-12-05 18:37:52 +01:00
Luca Di Maio 6d608248d0 docs: fix linting
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-09-26 17:44:50 +02:00
Luca Di Maio e89f05db2a CI: do not use scraping, use fixed version for pandoc
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-09-21 15:07:47 +02:00
Luca Di Maio 1e1ca193e8 generate-entry: auto-discover curl or wget. Fix #407
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-09-12 09:46:41 +02:00
Luca Di Maio c9be6e2eb7 all: add bash autocompletion. Fix #328
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-09-12 08:49:30 +02:00
Jan MackuandLuca Di Maio 4027617a55 CI: add another Shell linter - Differential-ShellCheck (#372)
* ci(lint): Add differential-shellcheck action

It performs differential ShellCheck scans and report results directly in
pull request.

documentation: https://github.com/redhat-plumbers-in-action/differential-shellcheck

Signed-off-by: Jan Macku <jamacku@redhat.com>
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Co-authored-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-09-01 18:22:06 +02:00
Luca Di Maio 627f8d2caf CI: fix rm command
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-08-31 07:49:33 +02:00
Luca Di Maio 9347305192 host-exec: fix formatting
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-07-11 21:14:21 +02:00
Luca Di Maio dce4fb08c4 Update issue templates
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-06-22 09:06:50 +02:00
Luca Di Maio 4f4ac28cfe CI: init is not working in github actions
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-06-11 18:33:26 +02:00
Luca Di Maio 19abd0b526 Update issue templates 2022-05-31 10:04:00 +02:00
Luca Di Maio 8462d96a6b CI: run ci only on PR that are specifically labeled and on main branch
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-05-29 13:01:22 +02:00
Luca Di Maio 21b6f8e13f CI: run ci only on PR that are specifically labeled
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-05-27 11:28:03 +02:00
Luca Di Maio cd49151432 CI/Lint: add auto-cancel to redundant workflows, mitigate use while working on #277
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
2022-05-26 00:39:24 +02:00
89luca89 16022bf9ad CI: generate manpages automatically 2022-05-06 18:49:04 +02:00
89luca89 8f350060e3 CI: run integration and compatibility tests only if we modify sensible parts of the software 2022-05-06 16:25:16 +02:00
89luca89 7f9fcdc449 CI: disable systemd checks for now, it seems incompatible with runner-provisioner.service on github 2022-04-27 20:44:38 +02:00
89luca89 466fba10d1 CI: add bashate to linters 2022-04-25 12:30:52 +02:00
89luca89 bf7c0ba556 CI: add markdownlint to Lint job 2022-04-05 18:21:37 +02:00
89luca89 b80eeab14b CI: always pull images before using distrobox 2022-03-30 14:34:27 +02:00
89luca89 82ec8b9881 Lint: use single tools instead of importing an action; reformat all to follow the style 2022-03-30 11:05:21 +02:00
89luca89 45b3fa392b CI: show container logs in case of failure 2022-03-25 21:31:56 +00:00
Luca Di Maio b22b3d28f5 create/CI: fix compatibility with init containers (#216)
* Fix compatibility with init containers
Fix #215

Right now systemd integration works only on docker, on podman it will
fail.
This is because docker daemon, running as root, has access to
/sys/fs/cgroup, while podman (rootless) does not.
Podman has a functionality to set up cgroups so that they work in
rootless mode as explained here: https://www.redhat.com/sysadmin/improved-systemd-podman

Right now the system is not triggered because it only checks if
entrypoint are `/sbin/init` or `/usr/bin/systemd`.

To fix this, let's force the use of systemd mode on podman if we're
using `--init`.

This problem went also undetected on the new CI as the `init` images are
tested as normal images. Let's also fix this and test create/enter on
init images using systemd commands.
2022-03-25 21:19:02 +01:00
Luca Di Maio 72035630a5 support environment variables to change defaults (#207)
* support environment variables to change defaults
* CI: test both podman and docker using new ENV variable

Implement use of environment variables to change defaults like:

 - container manager
 - default image to use
 - default name to use
 - interactivity

Variables will be respectively:

- DBX_CONTAINER_MANAGER
- DBX_CONTAINER_IMAGE
- DBX_CONTAINER_NAME
- DBX_NON_INTERACTIVE

This work opens also support for configuration rc-style files, in order of 
importance:

- /usr/share/distrobox/distrobox.conf
- /etc/distrobox/distrobox.conf
- ${HOME}/.config/distrobox/distrobox.conf
- ${HOME}/.distroboxrc
2022-03-20 15:08:30 +01:00
89luca89 218c9070fd CI: add max parallel to 8 2022-03-15 11:07:34 +00:00
Luca Di Maio ce229d729b CI: use main, not master 2022-03-15 11:57:38 +01:00
89luca89 9af6877750 CI: run on more occasions 2022-03-15 10:52:23 +00:00
Luca Di Maio 9916a7be75 CI: add compatibility test (#199)
* docs: update compatibility list
* docs: remove centos 8 compatibility, repos are not working anymore
* tests: add github action
2022-03-15 11:51:02 +01:00
89luca89 f402e8fba6 workflow: use dash noexec to check scripts 2022-02-01 02:06:51 +01:00
Luca Di Maio b2684ddfb1 Update issue templates 2022-01-04 11:02:59 +01:00
Luca Di Maio 018b8ca731 Update issue templates 2022-01-04 10:49:02 +01:00
Luca Di Maio aa88d20123 Update issue templates 2022-01-04 01:58:20 +01:00
Luca Di Maio 83c71e9d48 Add issue templates 2022-01-04 01:56:53 +01:00
89luca89 175abb6881 actions: specify shellcheck in posix sh 2021-12-15 20:26:06 +01:00
89luca89 8084b58778 create, enter: use eval to execute the generated command, remove shellcheck exception SC2091 2021-12-06 08:43:55 +01:00
89luca89 689d8e2716 Remove shellcheck exception, fix socket find command 2021-12-05 16:53:34 +01:00
89luca89 866d2a3c72 Remove shellcheck exception, fix default to variable 2021-12-05 16:39:54 +01:00
89luca89 e536a627fb Actions: enable on all PRs 2021-12-04 17:56:49 +01:00
89luca89 74927f6f58 Actions: add shellcheck linter action 2021-12-04 17:53:20 +01:00