From 00a9d2f94dee17e28e39cdae0c32acc3d1fe51ed Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Wed, 25 Jan 2017 08:56:15 -0500 Subject: [PATCH] Fix uninstall stopping ipa.service When uninstalling systemd is told to disable the service, but it is not told to sopt it, so it believes it is still running. This can cause issues in some cases if a reinstall is performed right after an uninstall, as systemd may decide to stop the disabled service while we are reinstalling, causing the new install to fail. https://fedorahosted.org/freeipa/ticket/5959 Signed-off-by: Simo Sorce Reviewed-By: Jan Cholasta --- ipaserver/install/server/install.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ipaserver/install/server/install.py b/ipaserver/install/server/install.py index a4490bbfc..dd04624fc 100644 --- a/ipaserver/install/server/install.py +++ b/ipaserver/install/server/install.py @@ -1034,9 +1034,13 @@ def uninstall(installer): print("Shutting down all IPA services") try: - run([paths.IPACTL, "stop"], raiseonerr=False) + services.knownservices.ipa.stop() except Exception: - pass + # Fallback to direct ipactl stop only if system command fails + try: + run([paths.IPACTL, "stop"], raiseonerr=False) + except Exception: + pass ntpinstance.NTPInstance(fstore).uninstall()