Add title to 'add' dialog for details of 'ID Views' entity

To improve translation quality the title of 'Add' dialog,
which is initialized within details of the entity, should be
specified explicitly in the spec and should be an entire sentence.

Fixes: https://pagure.io/freeipa/issue/7712
Fixes: https://pagure.io/freeipa/issue/7714
Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
This commit is contained in:
Stanislav Levin 2018-09-24 11:41:58 +03:00 committed by Serhii Tsymbaliuk
parent 9e4de506cb
commit 01eba53c80
2 changed files with 9 additions and 6 deletions

View File

@ -718,10 +718,8 @@ idviews.apply_action = function(spec) {
var pkey = facet.get_pkey(); var pkey = facet.get_pkey();
var other_entity = reg.entity.get(that.other_entity); var other_entity = reg.entity.get(that.other_entity);
var other_entity_label = other_entity.metadata.label;
var exclude = that.get_exclude(facet); var exclude = that.get_exclude(facet);
var title = text.get(that.dialog_title); var title = text.get(that.dialog_title);
title = title.replace('${entity}', other_entity_label);
title = title.replace('${primary_key}', pkey); title = title.replace('${primary_key}', pkey);
var dialog = IPA.association_adder_dialog({ var dialog = IPA.association_adder_dialog({

View File

@ -966,9 +966,13 @@ class i18n_messages(Command):
"appliedtohosts": _("Applied to hosts"), "appliedtohosts": _("Applied to hosts"),
"appliedtohosts_title": _("Applied to hosts"), "appliedtohosts_title": _("Applied to hosts"),
"apply_hostgroups": _("Apply to host groups"), "apply_hostgroups": _("Apply to host groups"),
"apply_hostgroups_title": _("Apply ID View ${primary_key} on hosts of ${entity}"), "apply_hostgroups_title": _(
"Apply ID view '${primary_key}' on hosts of host groups"
),
"apply_hosts": _("Apply to hosts"), "apply_hosts": _("Apply to hosts"),
"apply_hosts_title": _("Apply ID view ${primary_key} on ${entity}"), "apply_hosts_title": _(
"Apply ID view '${primary_key}' on hosts"
),
"ipaassignedidview": _("Assigned ID View"), "ipaassignedidview": _("Assigned ID View"),
"overrides_tab": _("${primary_key} overrides:"), "overrides_tab": _("${primary_key} overrides:"),
"remove": _("Remove ID views"), "remove": _("Remove ID views"),
@ -976,12 +980,13 @@ class i18n_messages(Command):
"remove_groups": _("Remove group ID overrides"), "remove_groups": _("Remove group ID overrides"),
"unapply_hostgroups": _("Un-apply from host groups"), "unapply_hostgroups": _("Un-apply from host groups"),
"unapply_hostgroups_all_title": _("Un-apply ID Views from hosts of hostgroups"), "unapply_hostgroups_all_title": _("Un-apply ID Views from hosts of hostgroups"),
"unapply_hostgroups_title": _("Un-apply ID View ${primary_key} from hosts of ${entity}"),
"unapply_hosts": _("Un-apply"), "unapply_hosts": _("Un-apply"),
"unapply_hosts_all": _("Un-apply from hosts"), "unapply_hosts_all": _("Un-apply from hosts"),
"unapply_hosts_all_title": _("Un-apply ID Views from hosts"), "unapply_hosts_all_title": _("Un-apply ID Views from hosts"),
"unapply_hosts_confirm": _("Are you sure you want to un-apply ID view from selected entries?"), "unapply_hosts_confirm": _("Are you sure you want to un-apply ID view from selected entries?"),
"unapply_hosts_title": _("Un-apply ID View ${primary_key} from hosts"), "unapply_hosts_title": _(
"Un-apply ID view '${primary_key}' from hosts"
),
}, },
"krbtpolicy": { "krbtpolicy": {
"identity": _("Kerberos Ticket Policy"), "identity": _("Kerberos Ticket Policy"),