IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-01-13 01:31:56 -06:00
Code Issues Packages Projects Releases Wiki Activity

Don't allow a group to be a member of itself.

Browse Source 
434542
This commit is contained in:
Rob Crittenden 2008-02-22 15:40:21 -05:00
parent 44797e3917
commit 02d3c5aff3
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ipa-python/ipaerror.py
View File

@ -138,6 +138,11 @@ INPUT_INVALID_PARAMETER = gen_error_code(
0x0001, 0x0001,
"Invalid parameter(s)") "Invalid parameter(s)")
INPUT_SAME_GROUP = gen_error_code(
INPUT_CATEGORY,
0x0002,
"You can't add a group to itself")
# #
# Connection errors # Connection errors
# #

6
ipa-server/xmlrpc-server/funcs.py
View File

@ -1258,6 +1258,8 @@ class IPAServer:
""" """
if not member_dn or not group_dn: if not member_dn or not group_dn:
raise ipaerror.gen_exception(ipaerror.INPUT_INVALID_PARAMETER) raise ipaerror.gen_exception(ipaerror.INPUT_INVALID_PARAMETER)
if member_dn.lower() == group_dn.lower():
raise ipaerror.gen_exception(ipaerror.INPUT_SAME_GROUP)
old_group = self.get_entry_by_dn(group_dn, None, opts) old_group = self.get_entry_by_dn(group_dn, None, opts)
if old_group is None: if old_group is None:
@ -1591,13 +1593,15 @@ class IPAServer:
return res return res
def add_group_to_group(self, group, tgroup, opts=None): def add_group_to_group(self, group, tgroup, opts=None):
"""Add a user to an existing group. """Add a group to an existing group.
group is a DN of the group to add group is a DN of the group to add
tgroup is the DN of the target group to be added to tgroup is the DN of the target group to be added to
""" """
if not group or not tgroup: if not group or not tgroup:
raise ipaerror.gen_exception(ipaerror.INPUT_INVALID_PARAMETER) raise ipaerror.gen_exception(ipaerror.INPUT_INVALID_PARAMETER)
if group.lower() == tgroup.lower():
raise ipaerror.gen_exception(ipaerror.INPUT_SAME_GROUP)
old_group = self.get_entry_by_dn(tgroup, None, opts) old_group = self.get_entry_by_dn(tgroup, None, opts)
if old_group is None: if old_group is None:
raise ipaerror.gen_exception(ipaerror.LDAP_NOT_FOUND) raise ipaerror.gen_exception(ipaerror.LDAP_NOT_FOUND)