logging: do not use ipa_log_manager to create module-level loggers

Replace all `ipa_log_manager.log_mgr.get_logger` calls to create
module-level loggers with `logging.getLogger` calls and deprecate
`ipa_log_manager.log_mgr.get_logger`.

Reviewed-By: Martin Basti <mbasti@redhat.com>

ipaplatform/base/tasks.py

@@ -22,13 +22,14 @@
 This module contains default platform-specific implementations of system tasks.
 '''
 
+import logging
+
 from pkg_resources import parse_version
 
 from ipaplatform.paths import paths
-from ipapython.ipa_log_manager import log_mgr
 from ipapython import ipautil
 
-log = log_mgr.get_logger(__name__)
+logger = logging.getLogger(__name__)
 
 
 class BaseTaskNamespace(object):
@@ -219,10 +220,10 @@ class BaseTaskNamespace(object):
         return False
 
     def add_user_to_group(self, user, group):
-        log.debug('Adding user %s to group %s', user, group)
+        logger.debug('Adding user %s to group %s', user, group)
         args = [paths.USERMOD, '-a', '-G', group, user]
         try:
             ipautil.run(args)
-            log.debug('Done adding user to group')
+            logger.debug('Done adding user to group')
         except ipautil.CalledProcessError as e:
-            log.debug('Failed to add user to group: %s', e)
+            logger.debug('Failed to add user to group: %s', e)

ipaplatform/redhat/tasks.py

@@ -25,6 +25,7 @@ system tasks.
 '''
 from __future__ import print_function
 
+import logging
 import os
 import pwd
 import shutil
@@ -41,7 +42,6 @@ from cffi import FFI
 from pyasn1.error import PyAsn1Error
 from six.moves import urllib
 
-from ipapython.ipa_log_manager import log_mgr
 from ipapython import ipautil
 import ipapython.errors
 
@@ -54,6 +54,8 @@ from ipaplatform.base.tasks import BaseTaskNamespace
 from ipalib.constants import IPAAPI_USER
 # pylint: enable=ipa-forbidden-import
 
+logger = logging.getLogger(__name__)
+
 _ffi = FFI()
 _ffi.cdef("""
 int rpmvercmp (const char *a, const char *b);
@@ -63,8 +65,6 @@ int rpmvercmp (const char *a, const char *b);
 # https://cffi.readthedocs.org/en/latest/overview.html#id8
 _librpm = _ffi.dlopen(find_library("rpm"))
 
-log = log_mgr.get_logger(__name__)
-
 
 def selinux_enabled():
     """
@@ -229,11 +229,11 @@ class RedHatTaskNamespace(BaseTaskNamespace):
         try:
             ipautil.run([paths.UPDATE_CA_TRUST])
         except CalledProcessError as e:
-            log.error(
+            logger.error(
                 "Could not update systemwide CA trust database: %s", e)
             return False
         else:
-            log.info("Systemwide CA database updated.")
+            logger.info("Systemwide CA database updated.")
             return True
 
     def insert_ca_certs_into_systemwide_ca_store(self, ca_certs):
@@ -248,7 +248,7 @@ class RedHatTaskNamespace(BaseTaskNamespace):
             try:
                 os.remove(new_cacert_path)
             except OSError as e:
-                log.error(
+                logger.error(
                     "Could not remove %s: %s", new_cacert_path, e)
                 return False
 
@@ -257,7 +257,7 @@ class RedHatTaskNamespace(BaseTaskNamespace):
         try:
             f = open(new_cacert_path, 'w')
         except IOError as e:
-            log.info("Failed to open %s: %s", new_cacert_path, e)
+            logger.info("Failed to open %s: %s", new_cacert_path, e)
             return False
 
         f.write("# This file was created by IPA. Do not edit.\n"
@@ -271,7 +271,7 @@ class RedHatTaskNamespace(BaseTaskNamespace):
                 serial_number = x509.get_der_serial_number(cert, x509.DER)
                 public_key_info = x509.get_der_public_key_info(cert, x509.DER)
             except (PyAsn1Error, ValueError, CertificateError) as e:
-                log.warning(
+                logger.warning(
                     "Failed to decode certificate \"%s\": %s", nickname, e)
                 continue
 
@@ -311,7 +311,7 @@ class RedHatTaskNamespace(BaseTaskNamespace):
                 try:
                     ext_key_usage = x509.encode_ext_key_usage(ext_key_usage)
                 except PyAsn1Error as e:
-                    log.warning(
+                    logger.warning(
                         "Failed to encode extended key usage for \"%s\": %s",
                         nickname, e)
                     continue
@@ -348,7 +348,7 @@ class RedHatTaskNamespace(BaseTaskNamespace):
             try:
                 os.remove(new_cacert_path)
             except OSError as e:
-                log.error(
+                logger.error(
                     "Could not remove %s: %s", new_cacert_path, e)
                 result = False
             else:
@@ -376,8 +376,8 @@ class RedHatTaskNamespace(BaseTaskNamespace):
             try:
                 self.set_hostname(old_hostname)
             except ipautil.CalledProcessError as e:
-                log.debug("%s", traceback.format_exc())
-                log.error(
+                logger.debug("%s", traceback.format_exc())
+                logger.error(
                     "Failed to restore this machine hostname to %s (%s).",
                     old_hostname, e
                 )
@@ -414,7 +414,7 @@ class RedHatTaskNamespace(BaseTaskNamespace):
                 if original_state != state:
                     updated_vars[setting] = state
             except ipautil.CalledProcessError as e:
-                log.error("Cannot get SELinux boolean '%s': %s", setting, e)
+                logger.error("Cannot get SELinux boolean '%s': %s", setting, e)
                 failed_vars[setting] = state
 
         if updated_vars:
@@ -481,12 +481,12 @@ class RedHatTaskNamespace(BaseTaskNamespace):
             os.unlink(paths.SYSTEMD_SYSTEM_HTTPD_IPA_CONF)
         except OSError as e:
             if e.errno == errno.ENOENT:
-                log.debug(
+                logger.debug(
                     'Trying to remove %s but file does not exist',
                     paths.SYSTEMD_SYSTEM_HTTPD_IPA_CONF
                 )
             else:
-                log.error(
+                logger.error(
                     'Error removing %s: %s',
                     paths.SYSTEMD_SYSTEM_HTTPD_IPA_CONF, e
                 )