IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Amend #2038 fix

Browse Source 
The math was unsafe, thanks to Nalin for spotting it.
This commit is contained in:
Simo Sorce
2011-11-04 16:40:25 -04:00
parent 9378e8b437
commit 08137836a3
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
util/ipa_krb5.c
View File

@@ -13,7 +13,7 @@ static krb5_error_code ipa_get_random_salt(krb5_context krbctx,
krb5_data *salt) krb5_data *salt)
{ {
krb5_error_code kerr; krb5_error_code kerr;
int i; int i, v;
/* make random salt */ /* make random salt */
salt->length = KRB5P_SALT_SIZE; salt->length = KRB5P_SALT_SIZE;
@@ -30,8 +30,10 @@ static krb5_error_code ipa_get_random_salt(krb5_context krbctx,
* To avoid any compatibility issue, limits octects only to * To avoid any compatibility issue, limits octects only to
* the ASCII printable range, or 0x20 <= val <= 0x7E */ * the ASCII printable range, or 0x20 <= val <= 0x7E */
for (i = 0; i < salt->length; i++) { for (i = 0; i < salt->length; i++) {
salt->data[i] %= 0x5E; /* 7E - 20 */ v = (unsigned char)salt->data[i];
salt->data[i] += 0x20; /* add base */ v %= 0x5E; /* 7E - 20 */
v += 0x20; /* add base */
salt->data[i] = v;
} }
return 0; return 0;