IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Replace float with Decimal

Browse Source 
Having float type as a base type for floating point parameters in
ipalib introduces several issues, e.g. problem with representation
or value comparison. Python language provides a Decimal type which
help overcome these issues.

This patch replaces a float type and Float parameter with a
decimal.Decimal type in Decimal parameter. A precision attribute
was added to Decimal parameter that can be used to limit a number
of decimal places in parameter representation. This approach fixes
a problem with API.txt validation where comparison of float values
may fail on different architectures due to float representation error.

In order to safely transfer the parameter value over RPC it is
being converted to string which is then converted back to
decimal.Decimal number on a server side.

https://fedorahosted.org/freeipa/ticket/2260
This commit is contained in:
Martin Kosek
2012-01-17 11:19:00 +01:00
parent d906fa50c1
commit 092dd8db12
11 changed files with 159 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ipaserver/rpcserver.py
View File

@@ -37,6 +37,7 @@ from ipapython.version import VERSION
import base64
import os
import string
from decimal import Decimal
_not_found_template = """<html>
<head>
<title>404 Not Found</title>
@@ -385,6 +386,8 @@ def json_encode_binary(val):
return new_list
elif isinstance(val, str):
return {'__base64__' : base64.b64encode(val)}
elif isinstance(val, Decimal):
return {'__base64__' : base64.b64encode(str(val))}
else:
return val