IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong use of identity operation

Browse Source 
Strings should not be compared with the identity operation 'is' or
'is not'.

Fixes: https://pagure.io/freeipa/issue/8057
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
This commit is contained in:
Christian Heimes
2019-09-03 13:55:27 +02:00
committed by Florence Blanc-Renaud
parent 8d2125f654
commit 0fc4b8c25c
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ipatests/test_xmlrpc/test_certmap_plugin.py
View File

@@ -451,7 +451,7 @@ class TestPermission(XMLRPC_test):
) as ewe:
find = certmap_rule.make_find_command()
res = find(**{k: v for k, v in certmaprule_create_params.items()
if k is not u'dn'})
if k != u'dn'})
ewe.send(res)
def test_update(self, certmap_rule, certmap_user_permissions):

4
ipatests/test_xmlrpc/tracker/user_plugin.py
View File

@@ -227,7 +227,7 @@ class UserTracker(CertmapdataMixin, KerberosAliasMixin, Tracker):
result = command()
for key, value in updates.items():
if value is None or value is '' or value is u'':
if value is None or value == '':
del self.attrs[key]
elif key == 'rename':
new_principal = u'{0}@{1}'.format(value, self.api.env.realm)
@@ -241,7 +241,7 @@ class UserTracker(CertmapdataMixin, KerberosAliasMixin, Tracker):
else:
self.attrs[key] = [value]
for key, value in expected_updates.items():
if value is None or value is '' or value is u'':
if value is None or value == '':
del self.attrs[key]
else:
self.attrs[key] = value