Issue 9497 - Update logging in ipa_enrollment

Fixes: https://pagure.io/freeipa/issue/9497

Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Mark Reynolds 2023-12-12 08:36:49 -05:00 committed by Florence Blanc-Renaud
parent 3fd5d57ed6
commit 1a16130a9a

View File

@ -30,7 +30,7 @@
* Program may make changes or additions to the list of Approved * Program may make changes or additions to the list of Approved
* Interfaces. * Interfaces.
* *
* Copyright (C) 2005 Red Hat, Inc. * Copyright (C) 2005-2023 Red Hat, Inc.
* All rights reserved. * All rights reserved.
* END COPYRIGHT BLOCK **/ * END COPYRIGHT BLOCK **/
@ -132,7 +132,8 @@ ipa_join(Slapi_PBlock *pb)
Slapi_DN *sdn; Slapi_DN *sdn;
Slapi_Backend *be; Slapi_Backend *be;
Slapi_Entry **es = NULL; Slapi_Entry **es = NULL;
int rc=0, ret=0, res, i; int rc=0, ret=0, res;
size_t i;
int is_root=0; int is_root=0;
char *krbLastPwdChange = NULL; char *krbLastPwdChange = NULL;
char *fqdn = NULL; char *fqdn = NULL;
@ -204,7 +205,7 @@ ipa_join(Slapi_PBlock *pb)
/* if there is none or more than one, freak out */ /* if there is none or more than one, freak out */
if (i != 1) { if (i != 1) {
LOG_TRACE("Too many entries, or entry no found (%d)", i); LOG_TRACE("Too many entries, or entry no found (%lu)\n", i);
if (i == 0) if (i == 0)
errMesg = "Host not found.\n"; errMesg = "Host not found.\n";
else else
@ -217,7 +218,7 @@ ipa_join(Slapi_PBlock *pb)
/* Is this host already enrolled? */ /* Is this host already enrolled? */
krbLastPwdChange = slapi_entry_attr_get_charptr(targetEntry, "krbLastPwdChange"); krbLastPwdChange = slapi_entry_attr_get_charptr(targetEntry, "krbLastPwdChange");
if (NULL != krbLastPwdChange) { if (NULL != krbLastPwdChange) {
LOG_TRACE("Host already enrolled"); LOG_TRACE("Host already enrolled\n");
errMesg = "Host already enrolled.\n"; errMesg = "Host already enrolled.\n";
rc = LDAP_OPERATIONS_ERROR; rc = LDAP_OPERATIONS_ERROR;
goto free_and_return; goto free_and_return;
@ -313,8 +314,8 @@ done:
ret = slapi_pblock_set(pb, SLAPI_EXT_OP_RET_OID, JOIN_OID); ret = slapi_pblock_set(pb, SLAPI_EXT_OP_RET_OID, JOIN_OID);
if (!ret) ret = slapi_pblock_set(pb, SLAPI_EXT_OP_RET_VALUE, &retbval); if (!ret) ret = slapi_pblock_set(pb, SLAPI_EXT_OP_RET_VALUE, &retbval);
if (ret) { if (ret) {
errMesg = "Could not set return values"; errMesg = "Could not set return values\n";
LOG("%s\n", errMesg); LOG("%s", errMesg);
rc = SLAPI_PLUGIN_EXTENDED_SENT_RESULT; rc = SLAPI_PLUGIN_EXTENDED_SENT_RESULT;
} }