IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

client: Do not create instance just to check isinstance

Browse Source 
Checking that classes are idenical gives the same result and
avoids unnecessary instantiation.

https://fedorahosted.org/freeipa/ticket/6048

Reviewed-By: Jan Cholasta <jcholast@redhat.com>
This commit is contained in:
David Kupka 2016-08-11 14:30:00 +02:00 committed by Jan Cholasta
parent 87a6f746bc
commit 1b79ac67d7
3 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ipaclient/plugins/automount.py
View File

@ -55,7 +55,7 @@ class _fake_automountlocation_show(Method):
class automountlocation_tofiles(MethodOverride):
@classmethod
def __NO_CLI_getter(cls):
return isinstance(api.Command.automountlocation_show,
return (api.Command.get_plugin('automountlocation_show') is
_fake_automountlocation_show)
NO_CLI = classproperty(__NO_CLI_getter)

3
ipaclient/plugins/otptoken_yubikey.py
View File

@ -77,8 +77,7 @@ class otptoken_add_yubikey(Command):
@classmethod
def __NO_CLI_getter(cls):
return isinstance(api.Command.otptoken_add,
_fake_otptoken_add)
return api.Command.get_plugin('otptoken_add') is _fake_otptoken_add
NO_CLI = classproperty(__NO_CLI_getter)

8
ipaclient/plugins/vault.py
View File

@ -205,7 +205,7 @@ class vault_add(Local):
@classmethod
def __NO_CLI_getter(cls):
return isinstance(api.Command.vault_add_internal,
return (api.Command.get_plugin('vault_add_internal') is
_fake_vault_add_internal)
NO_CLI = classproperty(__NO_CLI_getter)
@ -411,7 +411,7 @@ class vault_mod(Local):
@classmethod
def __NO_CLI_getter(cls):
return isinstance(api.Command.vault_mod_internal,
return (api.Command.get_plugin('vault_mod_internal') is
_fake_vault_mod_internal)
NO_CLI = classproperty(__NO_CLI_getter)
@ -598,7 +598,7 @@ class vault_archive(Local):
@classmethod
def __NO_CLI_getter(cls):
return isinstance(api.Command.vault_archive_internal,
return (api.Command.get_plugin('vault_archive_internal') is
_fake_vault_archive_internal)
NO_CLI = classproperty(__NO_CLI_getter)
@ -855,7 +855,7 @@ class vault_retrieve(Local):
@classmethod
def __NO_CLI_getter(cls):
return isinstance(api.Command.vault_retrieve_internal,
return (api.Command.get_plugin('vault_retrieve_internal') is
_fake_vault_retrieve_internal)
NO_CLI = classproperty(__NO_CLI_getter)