IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Removed usage of bitwise assignment operators in logical operations

Browse Source 
JavaScript &= and |= are bitwise operators. They are shortened version of:
 foo = foo & bar
 foo = foo | bar

In some places they were used as shortened version of logical operation and assignment.
 foo = foo && bar

It lead to type conversion to Number which is wrong (0 !== false).

This patch replaces such occurances with full version of logical operation and asignment.

https://fedorahosted.org/freeipa/ticket/2040
This commit is contained in:
Petr Vobornik
2011-12-05 13:39:30 +01:00
committed by Endi S. Dewata
parent c5ca34f41d
commit 1ffbec9942
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
install/ui/ipa.js
View File

@@ -725,8 +725,8 @@ IPA.concurrent_command = function(spec) {
for(var i=0; i < that.commands.length; i++) {
var command_info = that.commands[i];
all_completed &= command_info.completed;
all_success &= command_info.success;
all_completed = all_completed && command_info.completed;
all_success = all_success && command_info.success;
}
if(all_completed) {