IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

frontend: perform argument value validation only on server

Browse Source 
Do not validate values of command arguments on the client and let the
server handle validation.

This will make the client more lightweight by not having it to carry
validation code and metadata with itself for the price of increasing
network traffic in case the validation fails.

Types of the arguments are still validated on both the client and the
server.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
This commit is contained in:
Jan Cholasta
2016-04-05 13:11:20 +02:00
parent 13b010685b
commit 278fa29906
3 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ipalib/frontend.py
View File

@@ -448,7 +448,8 @@ class Command(HasParam):
self.debug(
'%s(%s)', self.name, ', '.join(self._repr_iter(**params))
)
self.validate(**params)
if self.api.env.in_server:
self.validate(**params)
(args, options) = self.params_2_args_options(**params)
ret = self.run(*args, **options)
if isinstance(ret, dict):
@@ -686,13 +687,18 @@ class Command(HasParam):
if param.name in dep:
if param.name in kw:
# Parameter is specified, convert and validate the value.
kw[param.name] = param(kw[param.name], **kw)
value = param(kw[param.name], **kw)
if self.api.env.in_server:
param.validate(value, supplied=True)
kw[param.name] = value
else:
# Parameter is not specified, use default value. Convert
# and validate the value, it might not be returned so
# there's no guarantee it will be converted and validated
# later.
default = param(None, **kw)
if self.api.env.in_server:
param.validate(default)
if default is not None:
kw[param.name] = default
hasdefault = True