From 29ca7bf30886e80e682bb7fc0ccdd2be0d226d4a Mon Sep 17 00:00:00 2001
From: Stanislav Levin <slev@altlinux.org>
Date: Tue, 25 Sep 2018 11:11:48 +0300
Subject: [PATCH] Add title to 'add' dialog for 'association_table' widget of
 Vaults entity

To improve translation quality the title of 'Add' dialog,
which is initialized within details table of the entity, should be
specified explicitly in the spec and should be an entire sentence.

Fixes: https://pagure.io/freeipa/issue/7712
Fixes: https://pagure.io/freeipa/issue/7714
Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
---
 install/ui/src/freeipa/vault.js |  6 ++++++
 ipaserver/plugins/internal.py   | 18 ++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/install/ui/src/freeipa/vault.js b/install/ui/src/freeipa/vault.js
index b10073ee9..2b4d116db 100644
--- a/install/ui/src/freeipa/vault.js
+++ b/install/ui/src/freeipa/vault.js
@@ -89,6 +89,7 @@ var make_vaults_details_page_spec = function() {
                                 label: '@i18n:objects.vault.user'
                             }
                         ],
+                        add_title: '@i18n:objects.vault.add_member_users',
                         remove_title: '@i18n:objects.vault.remove_member_users'
                     },
                     {
@@ -103,6 +104,7 @@ var make_vaults_details_page_spec = function() {
                                 label: '@i18n:objects.vault.group'
                             }
                         ],
+                        add_title: '@i18n:objects.vault.add_member_groups',
                         remove_title: '@i18n:objects.vault.remove_member_groups'
                     },
                     {
@@ -118,6 +120,7 @@ var make_vaults_details_page_spec = function() {
                                 label: '@i18n:objects.vault.service'
                             }
                         ],
+                        add_title: '@i18n:objects.vault.add_member_services',
                         remove_title: '@i18n:objects.vault.remove_member_services'
                     }
                 ]
@@ -141,6 +144,7 @@ var make_vaults_details_page_spec = function() {
                                 label: '@i18n:objects.vault.user'
                             }
                         ],
+                        add_title: '@i18n:objects.vault.add_owner_users',
                         remove_title: '@i18n:objects.vault.remove_owner_users'
                     },
                     {
@@ -157,6 +161,7 @@ var make_vaults_details_page_spec = function() {
                                 label: '@i18n:objects.vault.group'
                             }
                         ],
+                        add_title: '@i18n:objects.vault.add_owner_groups',
                         remove_title: '@i18n:objects.vault.remove_owner_groups'
                     },
                     {
@@ -174,6 +179,7 @@ var make_vaults_details_page_spec = function() {
                                 label: '@i18n:objects.vault.service'
                             }
                         ],
+                        add_title: '@i18n:objects.vault.add_owner_services',
                         remove_title: '@i18n:objects.vault.remove_owner_services'
                     }
                 ]
diff --git a/ipaserver/plugins/internal.py b/ipaserver/plugins/internal.py
index 146de0760..cc7e50358 100644
--- a/ipaserver/plugins/internal.py
+++ b/ipaserver/plugins/internal.py
@@ -1536,6 +1536,24 @@ class i18n_messages(Command):
             },
             "vault": {
                 "add": _("Add vault"),
+                "add_member_groups": _(
+                    "Add user groups into members of vault '${primary_key}'"
+                ),
+                "add_member_services": _(
+                    "Add services into members of vault '${primary_key}'"
+                ),
+                "add_member_users": _(
+                    "Add users into members of vault '${primary_key}'"
+                ),
+                "add_owner_groups": _(
+                    "Add user groups into owners of vault '${primary_key}'"
+                ),
+                "add_owner_services": _(
+                    "Add services into owners of vault '${primary_key}'"
+                ),
+                "add_owner_users": _(
+                    "Add users into owners of vault '${primary_key}'"
+                ),
                 "add_warn_arch_ret": _(
                     "Secrets can be added/retrieved to vault only by using "
                     "vault-archive and vault-retrieve from CLI."