From 31a5cf588e1171bcfd58d6a08a76867552dfe811 Mon Sep 17 00:00:00 2001 From: Stanislav Laznicka Date: Wed, 2 Aug 2017 16:05:16 +0200 Subject: [PATCH] conncheck: fix progression on failure traceback.format_exc() does not take exception object as an argument. This made Python 3 get stuck amid ipa-replica-conncheck, probably because it was waiting for a thread to finish. https://pagure.io/freeipa/issue/4985 Reviewed-By: Felipe Volpone --- install/tools/ipa-replica-conncheck | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/install/tools/ipa-replica-conncheck b/install/tools/ipa-replica-conncheck index 5014ac024..3db2e02cd 100755 --- a/install/tools/ipa-replica-conncheck +++ b/install/tools/ipa-replica-conncheck @@ -346,9 +346,9 @@ class PortResponder(threading.Thread): sock.listen(1) logger.debug('%d %s: Started listening', port, proto) - except socket.error as e: + except socket.error: logger.warning('%d %s: Failed to bind', port, proto) - logger.debug("%s", traceback.format_exc(e)) + logger.debug("%s", traceback.format_exc()) else: self._sockets.append(sock)