IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Re-order NULL check in ipa_lockout.

Browse Source 
There is no risk of crash here as slapi_valueset_first_value() can handle
the case where the valueset is NULL, but there is no point in calling that
if we know there are no values.

https://fedorahosted.org/freeipa/ticket/3880
This commit is contained in:
Rob Crittenden 2013-08-27 17:34:46 -04:00 committed by Petr Viktorin
parent f742520760
commit 3940a574f9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
daemons/ipa-slapi-plugins/ipa-lockout/ipa_lockout.c
View File

@ -244,9 +244,8 @@ int ipalockout_getpolicy(Slapi_Entry *target_entry, Slapi_Entry **policy_entry,
if (ldrc == 0) { if (ldrc == 0) {
Slapi_Value *sv = NULL; Slapi_Value *sv = NULL;
slapi_valueset_first_value(*values, &sv);
if (values != NULL) { if (values != NULL) {
slapi_valueset_first_value(*values, &sv);
*policy_dn = slapi_value_get_string(sv); *policy_dn = slapi_value_get_string(sv);
} }
} }