IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

schema: generate client-side commands on demand

Browse Source 
Instead of pre-generating all command classes from API schema on API
initialization and using them as plugins, use placeholder objects which
generate the classes on demand.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
This commit is contained in:
Jan Cholasta 2016-06-07 17:58:09 +02:00
parent 4128c565ea
commit 3ac2215ddb
1 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
ipaclient/remote_plugins/schema.py
View File

@ -47,7 +47,7 @@ _PARAMS = {
} }
class SchemaCommand(Command): class _SchemaCommand(Command):
def __fix_default_from(self, param): def __fix_default_from(self, param):
api = self.api api = self.api
name = self.name name = self.name
@ -76,14 +76,14 @@ class SchemaCommand(Command):
return param.clone(default_from=DefaultFrom(callback, *keys)) return param.clone(default_from=DefaultFrom(callback, *keys))
def get_args(self): def get_args(self):
for arg in super(SchemaCommand, self).get_args(): for arg in super(_SchemaCommand, self).get_args():
if arg.default_from is not None: if arg.default_from is not None:
arg = self.__fix_default_from(arg) arg = self.__fix_default_from(arg)
yield arg yield arg
def get_options(self): def get_options(self):
skip = set() skip = set()
for option in super(SchemaCommand, self).get_options(): for option in super(_SchemaCommand, self).get_options():
if option.name in skip: if option.name in skip:
continue continue
if option.name in ('all', 'raw'): if option.name in ('all', 'raw'):
@ -226,8 +226,31 @@ def _create_command(schema):
return command return command
class _LazySchemaCommand(object):
def __init__(self, schema):
self.__schema = schema
self.__class = None
self.__module__ = None
@property
def name(self):
return str(self.__schema['name'])
bases = (_SchemaCommand,)
def __call__(self, api):
if self.__class is None:
command = _create_command(self.__schema)
name = command.pop('name')
command = type(name, (_SchemaCommand,), command)
command.__module__ = self.__module__
self.__class = command
return self.__class(api)
def _create_commands(schema): def _create_commands(schema):
return [_create_command(s) for s in schema] return [_LazySchemaCommand(s) for s in schema]
def _create_topic(schema): def _create_topic(schema):
@ -281,11 +304,9 @@ def get_package(api):
sys.modules[module_name] = module sys.modules[module_name] = module
for command in commands: for command in commands:
name = command.pop('name')
command = type(name, (SchemaCommand,), command)
command.__module__ = module_name command.__module__ = module_name
command = module.register()(command) command = module.register()(command)
setattr(module, name, command) setattr(module, command.name, command)
for topic in topics: for topic in topics:
name = topic.pop('name') name = topic.pop('name')