From 3ba0375c831eca673c2df146b565a32dbc03fdb3 Mon Sep 17 00:00:00 2001 From: Fraser Tweedale Date: Mon, 6 Mar 2017 12:50:55 +1000 Subject: [PATCH] rabase.get_certificate: make serial number arg mandatory In rabase.get_certificate it does not make sense for the serial_number argument to be optional. Make it a mandatory positional argument. Part of: https://pagure.io/freeipa/issue/3473 Part of: https://pagure.io/freeipa/issue/5011 Reviewed-By: Tomas Krizek --- ipaserver/plugins/dogtag.py | 2 +- ipaserver/plugins/rabase.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ipaserver/plugins/dogtag.py b/ipaserver/plugins/dogtag.py index 80d499e2b..05b759da7 100644 --- a/ipaserver/plugins/dogtag.py +++ b/ipaserver/plugins/dogtag.py @@ -1502,7 +1502,7 @@ class ra(rabase.rabase, RestClient): return cmd_result - def get_certificate(self, serial_number=None): + def get_certificate(self, serial_number): """ Retrieve an existing certificate. diff --git a/ipaserver/plugins/rabase.py b/ipaserver/plugins/rabase.py index 49a3f8baf..0c8d7e265 100644 --- a/ipaserver/plugins/rabase.py +++ b/ipaserver/plugins/rabase.py @@ -59,7 +59,7 @@ class rabase(Backend): """ raise errors.NotImplementedError(name='%s.check_request_status' % self.name) - def get_certificate(self, serial_number=None): + def get_certificate(self, serial_number): """ Retrieve an existing certificate.