mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2025-01-11 00:31:56 -06:00
Make pycodestyle
results identical
Currently, pycodestyle is running on: - make fastlint: `$(PYTHON) -m pycodestyle --diff` According to docs: ``` The project options are read from the [pycodestyle] section of the tox.ini file or the setup.cfg file located in any parent folder of the path(s) being processed. ``` So, pycodestyle respects tox.ini: ``` [pycodestyle] # E402 module level import not at top of file # W504 line break after binary operator ignore = E402, W504 ``` - PR Travis `lint`: `pycodestyle --ignore=W504 --diff &> $PEP8_ERROR_LOG ||:` According to docs: ``` Please note that if the option –ignore=errors is used, the default configuration will be overridden and ignore only the check(s) you skip. ``` So, pycodestyle doesn't respect tox.ini. For now, fastlint ignores E402, W504, while Travis lint ignores only W504. This issue is exposed by Azure Pipelines, which employs fastlint. Fixes: https://pagure.io/freeipa/issue/7962 Signed-off-by: Stanislav Levin <slev@altlinux.org> Reviewed-By: Christian Heimes <cheimes@redhat.com>
This commit is contained in:
parent
a9bcf531a6
commit
3f33ac88bd
@ -34,7 +34,7 @@ then
|
|||||||
if [[ "$TRAVIS_EVENT_TYPE" == "pull_request" ]]
|
if [[ "$TRAVIS_EVENT_TYPE" == "pull_request" ]]
|
||||||
then
|
then
|
||||||
git diff origin/$TRAVIS_BRANCH -U0 | \
|
git diff origin/$TRAVIS_BRANCH -U0 | \
|
||||||
pycodestyle --ignore=W504 --diff &> $PEP8_ERROR_LOG ||:
|
pycodestyle --diff &> $PEP8_ERROR_LOG ||:
|
||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user