Pylint: enable check for unused-variables

Unused variables may:
* make code less readable
* create dead code
* potentialy hide issues/errors

Enabled check should prevent to leave unused variable in code

Check is locally disabled for modules that fix is not clear or easy or have too many occurences of
unused variables

Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>

client/ipa-client-automount

@@ -45,6 +45,7 @@ from ipaplatform.tasks import tasks
 from ipaplatform import services
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
 
 def parse_options():
     usage = "%prog [options]\n"

client/ipa-client-install

@@ -72,6 +72,8 @@ error was:
 """ % e, file=sys.stderr)
     sys.exit(1)
 
+# pylint: disable=unused-variable
+
 SUCCESS = 0
 CLIENT_INSTALL_ERROR = 1
 CLIENT_NOT_CONFIGURED = 2

daemons/dnssec/ipa-ods-exporter

@@ -41,6 +41,8 @@ from ipapython.dnssec.abshsm import sync_pkcs11_metadata, wrappingmech_name2id
 from ipapython.dnssec.ldapkeydb import LdapKeyDB
 from ipapython.dnssec.localhsm import LocalHSM
 
+# pylint: disable=unused-variable
+
 DAEMONNAME = 'ipa-ods-exporter'
 PRINCIPAL = None  # not initialized yet
 WORKDIR = os.path.join(paths.VAR_OPENDNSSEC_DIR ,'tmp')

install/certmonger/dogtag-ipa-ca-renew-agent-submit

@@ -44,6 +44,8 @@ from ipaplatform.paths import paths
 from ipaserver.plugins.ldap2 import ldap2
 from ipaserver.install import cainstance, certs
 
+# pylint: disable=unused-variable
+
 # This is a certmonger CA helper script for IPA CA subsystem cert renewal. See
 # https://git.fedorahosted.org/cgit/certmonger.git/tree/doc/submit.txt for more
 # info on certmonger CA helper scripts.

install/tools/ipa-adtrust-install

@@ -45,6 +45,8 @@ from ipaplatform.paths import paths
 from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

install/tools/ipa-replica-manage

@@ -45,6 +45,8 @@ from ipaclient import ipadiscovery
 from six.moves.xmlrpc_client import MAXINT
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 # dict of command name and tuples of min/max num of args needed
 commands = {
     "list":(0, 1, "[master fqdn]", ""),

install/tools/ipactl

@@ -39,6 +39,8 @@ from ipapython.dn import DN
 from ipaplatform import services
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 
 MSG_HINT_IGNORE_SERVICE_FAILURE = (
     "Hint: You can use --ignore-service-failure option for forced start in "

ipaclient/ipachangeconf.py

@@ -24,6 +24,8 @@ import shutil
 
 import six
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaclient/ipadiscovery.py

@@ -30,6 +30,8 @@ from ipaplatform.paths import paths
 from ipapython.ipautil import valid_ip, realm_to_suffix
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 NOT_FQDN = -1
 NO_LDAP_SERVER = -2
 REALM_NOT_FOUND = -3

ipaclient/plugins/cert.py

@@ -27,6 +27,8 @@ from ipalib.parameters import File, Flag, Str
 from ipalib.plugable import Registry
 from ipalib.text import _
 
+# pylint: disable=unused-variable
+
 register = Registry()
 
 

ipalib/certstore.py

@@ -29,6 +29,7 @@ from ipapython.dn import DN
 from ipapython.certdb import get_ca_nickname
 from ipalib import errors, x509
 
+# pylint: disable=unused-variable
 
 def _parse_cert(dercert):
     try:

ipalib/frontend.py

@@ -40,6 +40,8 @@ from ipalib import errors, messages
 from ipalib.request import context, context_frame
 from ipalib.util import classproperty, json_serialize
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipalib/parameters.py

@@ -119,6 +119,7 @@ from ipapython import kerberos
 from ipapython.dn import DN
 from ipapython.dnsutil import DNSName
 
+# pylint: disable=unused-variable
 
 def _is_null(value):
     return not value and value != 0 # NOTE: False == 0

ipalib/rpc.py

@@ -70,6 +70,8 @@ from ipapython.kerberos import Principal
 from ipalib.capabilities import VERSION_WITHOUT_CAPABILITIES
 from ipalib import api
 
+# pylint: disable=unused-variable
+
 # The XMLRPC client is in  "six.moves.xmlrpc_client", but pylint
 # cannot handle that
 try:

ipalib/util.py

@@ -51,6 +51,8 @@ from ipapython.dnsutil import DNSName
 from ipapython.dnsutil import resolve_ip_addresses
 from ipapython.ipa_log_manager import root_logger
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipapython/certdb.py

@@ -30,6 +30,8 @@ from ipapython.ipa_log_manager import root_logger
 from ipapython import ipautil
 from ipalib import x509
 
+# pylint: disable=unused-variable
+
 CA_NICKNAME_FMT = "%s IPA CA"
 
 

ipapython/certmonger.py

@@ -34,6 +34,8 @@ from ipapython.ipa_log_manager import root_logger
 from ipaplatform.paths import paths
 from ipaplatform import services
 
+# pylint: disable=unused-variable
+
 DBUS_CM_PATH = '/org/fedorahosted/certmonger'
 DBUS_CM_IF = 'org.fedorahosted.certmonger'
 DBUS_CM_NAME = 'org.fedorahosted.certmonger'

ipapython/cookie.py

@@ -27,6 +27,8 @@ from six.moves.urllib.parse import urlparse
 
 from ipapython.ipa_log_manager import log_mgr
 
+# pylint: disable=unused-variable
+
 '''
 Core Python has two cookie libraries, Cookie.py targeted to server
 side and cookielib.py targeted to client side. So why this module and

ipapython/dnssec/localhsm.py

@@ -18,6 +18,8 @@ from ipapython.dnssec.abshsm import (attrs_name2id, attrs_id2name, AbstractHSM,
                                      keytype_id2name, keytype_name2id,
                                      ldap2p11helper_api_params)
 
+# pylint: disable=unused-variable
+
 private_key_api_params = set(["label", "id", "data", "unwrapping_key",
     "wrapping_mech", "key_type", "cka_always_authenticate", "cka_copyable",
     "cka_decrypt", "cka_derive", "cka_extractable", "cka_modifiable",

ipapython/install/core.py

@@ -19,6 +19,8 @@ from ipapython.ipa_log_manager import root_logger
 from . import util
 from .util import from_
 
+# pylint: disable=unused-variable
+
 __all__ = ['InvalidStateError', 'KnobValueError', 'Property', 'Knob',
            'Configurable', 'Group', 'Component', 'Composite']
 

ipapython/ipaldap.py

@@ -44,6 +44,8 @@ from ipapython.dn import DN
 from ipapython.dnsutil import DNSName
 from ipapython.kerberos import Principal
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipapython/ipautil.py

@@ -54,6 +54,8 @@ from ipapython import config
 from ipaplatform.paths import paths
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 SHARE_DIR = paths.USR_SHARE_IPA_DIR
 PLUGINS_SHARE_DIR = paths.IPA_PLUGINS
 

ipapython/p11helper.py

@@ -12,6 +12,8 @@ from cryptography.hazmat.primitives import serialization
 from cryptography.hazmat.primitives.asymmetric import dsa, ec, rsa
 from cffi import FFI
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipapython/sysrestore.py

@@ -35,6 +35,8 @@ from six.moves.configparser import SafeConfigParser
 from ipaplatform.tasks import tasks
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/dcerpc.py

@@ -63,6 +63,8 @@ from ipaplatform.paths import paths
 from ldap.filter import escape_filter_chars
 from time import sleep
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
     long = int

ipaserver/install/bindinstance.py

@@ -60,6 +60,8 @@ from ipalib.util import (validate_zonemgr_str, normalize_zonemgr,
                          UnresolvableRecordError)
 from ipalib.constants import CACERT
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/install/ca.py

@@ -15,6 +15,8 @@ from ipalib import api, certstore, x509
 from ipapython.dn import DN
 from ipapython.ipa_log_manager import root_logger
 
+# pylint: disable=unused-variable
+
 external_cert_file = None
 external_ca_file = None
 

ipaserver/install/cainstance.py

@@ -81,6 +81,7 @@ try:
 except ImportError:
     import http.client as httplib
 
+# pylint: disable=unused-variable
 
 # We need to reset the template because the CA uses the regular boot
 # information

ipaserver/install/certs.py

@@ -45,6 +45,8 @@ from ipalib.text import _
 from ipaplatform.constants import constants
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 # Apache needs access to this database so we need to create it
 # where apache can reach
 NSS_DIR = paths.HTTPD_ALIAS_DIR

ipaserver/install/dns.py

@@ -34,6 +34,8 @@ from ipaserver.install import ntpinstance
 from ipaserver.install import odsexporterinstance
 from ipaserver.install import opendnssecinstance
 
+# pylint: disable=unused-variable
+
 ip_addresses = []
 reverse_zones = []
 

ipaserver/install/dnskeysyncinstance.py

@@ -28,6 +28,8 @@ from ipalib import errors, api
 from ipalib.constants import CACERT
 from ipaserver.install.bindinstance import dns_container_exists
 
+# pylint: disable=unused-variable
+
 softhsm_token_label = u'ipaDNSSEC'
 softhsm_slot = 0
 replica_keylabel_template = u"dnssec-replica:%s"

ipaserver/install/dogtaginstance.py

@@ -45,6 +45,8 @@ from ipaserver.install import replication
 from ipaserver.install.installutils import stopped_service
 from ipapython.ipa_log_manager import log_mgr
 
+# pylint: disable=unused-variable
+
 HTTPD_USER = constants.HTTPD_USER
 
 

ipaserver/install/dsinstance.py

@@ -52,6 +52,8 @@ from ipapython.admintool import ScriptError
 from ipaplatform import services
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 DS_USER = platformconstants.DS_USER
 DS_GROUP = platformconstants.DS_GROUP
 

ipaserver/install/ipa_backup.py

@@ -40,6 +40,8 @@ from ipalib.constants import CACERT
 from ipaplatform.constants import constants
 from ipaplatform.tasks import tasks
 
+# pylint: disable=unused-variable
+
 """
 A test gpg can be generated like this:
 

ipaserver/install/ipa_cacert_manage.py

@@ -31,6 +31,8 @@ from ipaplatform.paths import paths
 from ipalib import api, errors, x509, certstore
 from ipaserver.install import certs, cainstance, installutils
 
+# pylint: disable=unused-variable
+
 
 class CACertManage(admintool.AdminTool):
     command_name = 'ipa-cacert-manage'

ipaserver/install/ipa_replica_prepare.py

@@ -43,6 +43,7 @@ from ipalib import errors
 from ipaplatform.paths import paths
 from ipalib.constants import CACERT, DOMAIN_LEVEL_0
 
+# pylint: disable=unused-variable
 
 UNSUPPORTED_DOMAIN_LEVEL_TEMPLATE = """
 Replica creation using '{command_name}' to generate replica file

ipaserver/install/ipa_restore.py

@@ -51,6 +51,7 @@ try:
 except ImportError:
     adtrustinstance = None
 
+# pylint: disable=unused-variable
 
 def recursive_chown(path, uid, gid):
     '''

ipaserver/install/ipa_winsync_migrate.py

@@ -29,6 +29,8 @@ from ipapython.dn import DN
 from ipapython.ipautil import realm_to_suffix, posixify
 from ipaserver.install import replication, installutils
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/install/opendnssecinstance.py

@@ -20,6 +20,8 @@ from ipaplatform.paths import paths
 from ipalib import errors, api
 from ipaserver.install import dnskeysyncinstance
 
+# pylint: disable=unused-variable
+
 KEYMASTER = u'dnssecKeyMaster'
 softhsm_slot = 0
 

ipaserver/install/plugins/rename_managed.py

@@ -24,6 +24,8 @@ from ipalib import Updater
 from ipapython import ipautil
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 register = Registry()
 
 if six.PY3:

ipaserver/install/replication.py

@@ -38,6 +38,8 @@ from ipapython.dn import DN
 from ipaplatform import services
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/install/server/install.py

@@ -59,6 +59,8 @@ except ImportError:
 
 from .common import BaseServer, BaseServerCA
 
+# pylint: disable=unused-variable
+
 SYSRESTORE_DIR_PATH = paths.SYSRESTORE
 
 

ipaserver/install/server/replicainstall.py

@@ -47,6 +47,8 @@ from binascii import hexlify
 
 from .common import BaseServer
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/install/server/upgrade.py

@@ -49,6 +49,8 @@ from ipaserver.install import dogtaginstance
 from ipaserver.install.upgradeinstance import IPAUpgrade
 from ipaserver.install.ldapupdate import BadSyntax
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/install/upgradeinstance.py

@@ -30,6 +30,8 @@ from ipaserver.install import schemaupdate
 from ipaserver.install import ldapupdate
 from ipaserver.install import service
 
+# pylint: disable=unused-variable
+
 DSE = 'dse.ldif'
 
 

ipaserver/plugins/aci.py

@@ -132,6 +132,8 @@ from .baseldap import gen_pkey_only_option, pkey_to_value
 from ipapython.ipa_log_manager import root_logger
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/baseldap.py

@@ -39,6 +39,8 @@ from ipalib.messages import add_message, SearchResultTruncated
 from ipapython.dn import DN
 from ipapython.version import API_VERSION
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/cert.py

@@ -53,6 +53,8 @@ from ipapython.dn import DN
 from ipapython.ipa_log_manager import root_logger
 from ipaserver.plugins.service import normalize_principal, validate_realm
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/dns.py

@@ -85,6 +85,8 @@ from ipaserver.dns_data_management import (
     IPADomainIsNotManagedByIPAError,
 )
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/dogtag.py

@@ -259,6 +259,8 @@ if api.env.in_server:
     import pki.crypto as cryptoutil
     from pki.kra import KRAClient
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/idrange.py

@@ -26,6 +26,8 @@ from ipalib import api, Int, Str, StrEnum, _, ngettext
 from ipalib import errors
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/idviews.py

@@ -40,6 +40,8 @@ from ipalib.util import (normalize_sshpubkey, validate_sshpubkey,
 
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/migration.py

@@ -40,6 +40,8 @@ from ipapython.kerberos import Principal
 import datetime
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/permission.py

@@ -33,6 +33,8 @@ from ipalib.aci import ACI
 from ipapython.dn import DN
 from ipalib.request import context
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/stageuser.py

@@ -50,6 +50,8 @@ from ipaplatform.paths import paths
 from ipapython.ipautil import ipa_generate_password, GEN_TMP_PWD_LEN
 from ipalib.capabilities import client_has_capability
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/trust.py

@@ -45,6 +45,8 @@ from ipalib import output
 from ldap import SCOPE_SUBTREE
 from time import sleep
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/plugins/user.py

@@ -69,6 +69,8 @@ from ipalib.capabilities import client_has_capability
 if api.env.in_server:
     from ipaserver.plugins.ldap2 import ldap2
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipaserver/rpcserver.py

@@ -64,6 +64,8 @@ from ipaplatform.paths import paths
 from ipapython.version import VERSION
 from ipalib.text import _
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipatests/pytest_plugins/integration.py

@@ -34,6 +34,7 @@ from ipatests.test_integration import tasks
 from ipatests.test_integration.config import Config
 from ipatests.test_integration.env_config import get_global_config
 
+# pylint: disable=unused-variable
 
 log = log_mgr.get_logger(__name__)
 

ipatests/test_install/test_updates.py

@@ -34,6 +34,8 @@ from ipapython import ipautil, ipaldap
 from ipaplatform.paths import paths
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 """
 The updater works through files only so this is just a thin-wrapper controlling
 which file we test at any given point.

ipatests/test_integration/tasks.py

@@ -44,6 +44,8 @@ from ipalib.util import get_reverse_zone_default, verify_host_resolvable
 from ipalib.constants import DOMAIN_SUFFIX_NAME
 from ipalib.constants import DOMAIN_LEVEL_0
 
+# pylint: disable=unused-variable
+
 log = log_mgr.get_logger(__name__)
 
 

ipatests/test_ipalib/test_frontend.py

@@ -36,6 +36,8 @@ from ipalib import output, messages
 from ipalib.parameters import Str
 from ipapython.version import API_VERSION
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipatests/test_ipalib/test_parameters.py

@@ -43,6 +43,8 @@ from ipalib.constants import TYPE_ERROR, CALLABLE_ERROR
 from ipalib.errors import ValidationError, ConversionError
 from ipalib import _
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
     long = int

ipatests/test_ipalib/test_rpc.py

@@ -34,6 +34,8 @@ from ipalib.request import context, Connection
 from ipalib import rpc, errors, api, request
 from ipapython.version import API_VERSION
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipatests/test_ipaserver/test_rpcserver.py

@@ -30,6 +30,8 @@ from ipatests.util import assert_equal, raises, PluginTester
 from ipalib import errors
 from ipaserver import rpcserver
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipatests/test_ipaserver/test_serverroles.py

@@ -15,6 +15,7 @@ from ipalib import api, create_api, errors
 from ipapython.dn import DN
 from ipatests.util import MockLDAP
 
+# pylint: disable=unused-variable
 
 def _make_service_entry_mods(enabled=True, other_config=None):
     mods = {

ipatests/test_xmlrpc/test_sudorule_plugin.py

@@ -29,6 +29,8 @@ from ipalib import api
 from ipalib import errors
 import pytest
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

pylintrc

@@ -55,7 +55,6 @@ disable=
     undefined-loop-variable,
     unnecessary-lambda,
     unused-argument,
-    unused-variable,
     useless-else-on-loop,
     bad-continuation,
     bad-whitespace,
@@ -93,3 +92,7 @@ reports=no
 # Template used to display messages. This is a python new-style format string
 # used to format the message information. See doc for all details
 msg-template='{path}:{line}: [{msg_id}({symbol}), {obj}] {msg})'
+
+
+[VARIABLES]
+dummy-variables-rgx=_.+