ipa-upgradeconfig: Remove backed up smb.conf

Since we are not able to properly restore the Samba server to the
working state after running ipa-adtrust-install, we should not keep
the smb.conf in the fstore.

This patch makes sure that any backed up smb.conf is removed from
the backup and that this file is not backed up anymore.

Part of: https://fedorahosted.org/freeipa/ticket/3479
This commit is contained in:
Tomas Babej
2013-10-09 12:23:18 +02:00
committed by Martin Kosek
parent 285ed59889
commit 4a95a50596
2 changed files with 20 additions and 9 deletions

View File

@@ -365,8 +365,6 @@ class ADTRUSTInstance(service.Service):
self.admin_conn.add_entry(entry)
def __write_smb_conf(self):
self.fstore.backup_file(self.smb_conf)
conf_fd = open(self.smb_conf, "w")
conf_fd.write('### Added by IPA Installer ###\n')
conf_fd.write('[global]\n')
@@ -863,18 +861,17 @@ class ADTRUSTInstance(service.Service):
except:
pass
for r_file in [self.smb_conf]:
try:
self.fstore.restore_file(r_file)
except ValueError, error:
root_logger.debug(error)
pass
# Since we do not guarantee restoring back to working samba state,
# we should not restore smb.conf
# Restore the state of affected selinux booleans
for var in self.selinux_booleans:
sebool_state = self.restore_state(var)
if not sebool_state is None:
try:
ipautil.run(["/usr/sbin/setsebool", "-P", var, sebool_state])
ipautil.run(["/usr/sbin/setsebool",
"-P", var, sebool_state])
except:
self.print_msg(SELINUX_WARNING % dict(var=var))