IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Added error handler for ipa_cmd().

Browse Source 
The ipa_cmd() has been modified such that when an error occurs a
dialog box will appear showing the error message with 2 buttons:
Retry and Cancel. If Retry is clicked, it will attempt to execute
the same operation again. If Cancel is clicked, the operation will
be canceled and the control is returned to the caller.

New unit tests have been added to test ipa_cmd() on successfull
and unsuccessfull cases.

The associate.js, details.js, entity.js, search.js, and webui.js
have been modified to display the error message inside the page.
This behavior can be changed in the future (e.g. redirect to error
page).

The navigation.js and webui.js have been modified to render only
the visible tabs. This improves the performance and reduce hidden
errors. The navigation unit test has been modified to reflect this
behavior.

Some variables/functions also have been renamed for consistency.
This commit is contained in:
Endi S. Dewata
2010-09-29 00:52:56 -05:00
committed by Adam Young
parent 09555fae17
commit 4b4ecef4a3
10 changed files with 380 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
install/static/details.js
View File

@@ -37,20 +37,24 @@ function ipa_details_create(obj_name, dls, container)
container.attr('title', obj_name);
container.addClass('details-container');
container.append('<div class="details-buttons"></div>');
var jobj = container.children().last();
var details = $('<div/>', {
class: 'details'
}).appendTo(container);
details.append('<div class="details-buttons"></div>');
var jobj = details.children().last();
jobj.append('<a class="details-reset" href="jslink">Reset</a>');
jobj.append('<a class="details-update" href="jslink">Update</a>');
container.append('<hr />');
details.append('<hr />');
for (var i = 0; i < dls.length; ++i) {
var d = dls[i];
ipa_generate_dl(container.children().last(), d[0], d[1], d[2]);
ipa_generate_dl(details.children().last(), d[0], d[1], d[2]);
}
container.append('<div class="details-back"></div>');
var jobj = container.children().last();
details.append('<div class="details-back"></div>');
var jobj = details.children().last();
jobj.append('<a href="#details-viewtype">Back to Top</a>');
}
@@ -87,8 +91,10 @@ function ipa_generate_dl(jobj, id, name, dts)
jobj.after('<hr />');
}
function ipa_details_load(obj_name, pkey, on_win, on_fail, sampleData)
function ipa_details_load(jobj, pkey, on_win, on_fail)
{
var obj_name = jobj.attr('id');
function load_on_win(data, text_status, xhr) {
if (on_win)
on_win(data, text_status, xhr);
@@ -103,14 +109,17 @@ function ipa_details_load(obj_name, pkey, on_win, on_fail, sampleData)
function load_on_fail(xhr, text_status, error_thrown) {
if (on_fail)
on_fail(xhr, text_status, error_thrown);
var details = $('.details', jobj).empty();
details.append('<p>Error: '+error_thrown.name+'</p>');
details.append('<p>'+error_thrown.message+'</p>');
};
if (!pkey)
return;
ipa_cmd(
'show', [pkey], {all: true}, load_on_win, load_on_fail,
obj_name, sampleData
'show', [pkey], {all: true}, load_on_win, load_on_fail, obj_name
);
}
@@ -301,7 +310,7 @@ var _ipa_param_type_2_handler_map = {
'Str': _ipa_create_text_input,
'Int': _ipa_create_text_input,
'Bool': _ipa_create_text_input,
'List': _ipa_create_text_input,
'List': _ipa_create_text_input
};
/* create an HTML element for displaying/editing an attribute