IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

ipatests: some tests are date-sensitive and fail Feb 29

Browse Source 
A few tests are changing the date back and forth using for
instance date -s +3Years+1day and date -s -3Years-1day.
This method does not bring the system back to the current date
if executed around Feb 28 or 29 on a leap year, and may result
in de-synchronized server and client.

Add a note in the test to warn about potential future failures.

Related: https://pagure.io/freeipa/issue/9548

Signed-off-by: Florence Blanc-Renaud <flo@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Florence Blanc-Renaud 2024-02-29 16:01:33 +01:00
parent f4a1696a3b
commit 558a7de8b7
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ipatests/test_integration/test_commands.py
View File

@ -1575,6 +1575,17 @@ class TestIPACommand(IntegrationTest):
# upload script and run with Python executable # upload script and run with Python executable
script = "/tmp/example_cli.py" script = "/tmp/example_cli.py"
host.put_file_contents(script, contents) host.put_file_contents(script, contents)
# Important: this test is date-sensitive and may fail if executed
# around Feb 28 or Feb 29 on a leap year.
# The previous tests are playing with the date by jumping in the
# future and back to the (expected) current date but calling
# date -s +15Years and then date -s -15Years doesn't
# bring the date back to the original value if called around Feb 29.
# As a consequence, client and server are not synchronized any more
# and client API authentication may fail with the following error:
# ipalib.errors.KerberosError:
# No valid Negotiate header in server response
# If you see this failure, just ignore and relaunch on March 1.
result = host.run_command([sys.executable, script]) result = host.run_command([sys.executable, script])
# script prints admin account # script prints admin account

11
ipatests/test_integration/test_ipa_cert_fix.py
View File

@ -391,6 +391,17 @@ class TestCertFixReplica(IntegrationTest):
tasks.install_master( tasks.install_master(
mh.master, setup_dns=False, extra_args=['--no-ntp'] mh.master, setup_dns=False, extra_args=['--no-ntp']
) )
# Important: this test is date-sensitive and may fail if executed
# around Feb 28 or Feb 29 on a leap year.
# The previous tests are playing with the date by jumping in the
# future and back to the (expected) current date but calling
# date -s +3Years+1day and then date -s -3Years-1day doesn't
# bring the date back to the original value if called around Feb 29.
# As a consequence, client and server are not synchronized any more
# and client installation may fail with the following error:
# Joining realm failed: JSON-RPC call failed:
# SSL peer certificate or SSH remote key was not OK
# If you see this failure, just ignore and relaunch on March 1.
tasks.install_replica( tasks.install_replica(
mh.master, mh.replicas[0], mh.master, mh.replicas[0],
setup_dns=False, extra_args=['--no-ntp'] setup_dns=False, extra_args=['--no-ntp']