pylint: Fix useless-suppression

Cleanup up no longer used Pylint's disables where possible.

Fixes: https://pagure.io/freeipa/issue/9117
Signed-off-by: Stanislav Levin <slev@altlinux.org>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>

ipapython/admintool.py

@@ -180,9 +180,8 @@ class AdminTool:
             return_value = self.run()
         except BaseException as exception:
             if isinstance(exception, ScriptError):
-                # pylint: disable=no-member
                 if exception.rval and exception.rval > return_value:
-                    return_value = exception.rval  # pylint: disable=no-member
+                    return_value = exception.rval
             traceback = sys.exc_info()[2]
             error_message, return_value = self.handle_error(exception)
             if return_value:
@@ -244,7 +243,7 @@ class AdminTool:
         root_logger = logging.getLogger()
         for handler in root_logger.handlers:
             if (isinstance(handler, logging.StreamHandler) and
-                    handler.stream is sys.stderr):  # pylint: disable=no-member
+                    handler.stream is sys.stderr):
                 root_logger.removeHandler(handler)
                 break
 

ipapython/dnsutil.py

@@ -162,7 +162,6 @@ class DNSName(dns.name.Name):
     def __init__(self, labels, origin=None):
         try:
             if isinstance(labels, str):
-                #pylint: disable=E1101
                 labels = dns.name.from_text(unicode(labels), origin).labels
             elif isinstance(labels, dns.name.Name):
                 labels = labels.labels

ipapython/dogtag.py

@@ -41,7 +41,6 @@ from ipapython import ipautil
 try:
     import httplib
 except ImportError:
-    # pylint: disable=import-error
     import http.client as httplib
 
 if six.PY3:
@@ -67,7 +66,7 @@ KDC_PROFILE = u'KDCs_PKINIT_Certs'
 
 
 if six.PY3:
-    gzip_decompress = gzip.decompress  # pylint: disable=no-member
+    gzip_decompress = gzip.decompress
 else:
     # note: gzip.decompress available in Python >= 3.2
     def gzip_decompress(data):

ipapython/ipachangeconf.py

@@ -216,7 +216,7 @@ class IPAChangeConf:
         if value:
             return {'name': 'comment',
                     'type': 'comment',
-                    'value': value.rstrip()}  # pylint: disable=E1103
+                    'value': value.rstrip()}
 
         o = dict()
         parts = line.split(self.dassign, 1)

ipapython/ipaldap.py

@@ -84,7 +84,7 @@ if six.PY2 and hasattr(ldap, 'LDAPBytesWarning'):
     # XXX silence python-ldap's BytesWarnings
     warnings.filterwarnings(
         action="ignore",
-        category=ldap.LDAPBytesWarning,  # pylint: disable=no-member
+        category=ldap.LDAPBytesWarning,
     )
 
 
@@ -255,7 +255,7 @@ class LDAPEntry(MutableMapping):
 
         Keyword arguments can be used to override values of specific attributes.
         """
-        super(LDAPEntry, self).__init__()  # pylint: disable=no-member
+        super(LDAPEntry, self).__init__()
 
         if isinstance(_conn, LDAPEntry):
             assert _dn is None
@@ -284,7 +284,6 @@ class LDAPEntry(MutableMapping):
         self._single_value_view = None
 
         if isinstance(_obj, LDAPEntry):
-            #pylint: disable=E1103
             self._not_list = set(_obj._not_list)
             self._orig_raw = dict(_obj._orig_raw)
             if _obj.conn is _conn:
@@ -1933,7 +1932,6 @@ class LDAPCache(LDAPClient):
 
     def get_entry(self, dn, attrs_list=None, time_limit=None,
                   size_limit=None, get_effective_rights=False):
-        # pylint: disable=no-member
         if not self._enable_cache:
             return super(LDAPCache, self).get_entry(
                 dn, attrs_list, time_limit, size_limit, get_effective_rights
@@ -1971,7 +1969,6 @@ class LDAPCache(LDAPClient):
             get_all = True
 
         if entry and entry.all and get_all:
-            # self.hit  # pylint: disable=pointless-statement
             hits = self._cache_hits + 1  # pylint: disable=no-member
             object.__setattr__(self, '_cache_hits', hits)
             self.cache_status('HIT')

ipapython/ipautil.py

@@ -544,7 +544,7 @@ def run(args, stdin=None, raiseonerr=True, nolog=(), env=None,
         raise
     finally:
         if skip_output:
-            p_out.close()   # pylint: disable=E1103
+            p_out.close()
 
     logger.debug('Process finished, return code=%s', p.returncode)
 
@@ -1513,7 +1513,7 @@ if six.PY2:
                 str.__name__,
                 type(value).__name__))
 else:
-    fsdecode = os.fsdecode  #pylint: disable=no-member
+    fsdecode = os.fsdecode
 
 
 def unescape_seq(seq, *args):

ipapython/ssh.py

@@ -26,7 +26,7 @@ import base64
 import re
 import struct
 from hashlib import sha1
-from hashlib import sha256  # pylint: disable=E0611
+from hashlib import sha256
 
 import six