IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix coverity issues

Browse Source 
Reviewed-By: Martin Basti <mbasti@redhat.com>
This commit is contained in:
Ludwig Krispenz 2015-06-16 11:14:37 +02:00 committed by Petr Vobornik
parent 4d7b630992
commit 5e92c981b0
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
daemons/ipa-slapi-plugins/topology/topology_util.c
View File

@ -192,7 +192,11 @@ ipa_topo_util_get_replica_conf(char *repl_root)
slapi_free_search_results_internal(pb);
slapi_pblock_destroy(pb);
if (0 != ipa_topo_cfg_replica_add(topoRepl)) {
if (0 == topoRepl) {
slapi_log_error(SLAPI_LOG_FATAL, IPA_TOPO_PLUGIN_SUBSYSTEM,
"ipa_topo_util_get_replica_conf: "
"cannot create replica\n");
} else if (0 != ipa_topo_cfg_replica_add(topoRepl)) {
slapi_log_error(SLAPI_LOG_FATAL, IPA_TOPO_PLUGIN_SUBSYSTEM,
"ipa_topo_util_get_replica_conf: "
"replica already exists\n");
@ -1325,6 +1329,14 @@ ipa_topo_util_delete_segments_for_host(char *repl_root, char *delhost)
TopoReplica *tconf = ipa_topo_cfg_replica_find(repl_root, 1);
int check_reverse = 1;
if (NULL == tconf) {
slapi_log_error(SLAPI_LOG_PLUGIN, IPA_TOPO_PLUGIN_SUBSYSTEM,
"ipa_topo_util_delete_segments_for_host: "
"failed to get replica object for suffix: %s \n",
repl_root);
return;
}
/* first check if a segment originating at localhost exists */
segm = ipa_topo_cfg_segment_find(repl_root, ipa_topo_get_plugin_hostname(),
delhost, SEGMENT_LEFT_RIGHT);