From 65bde3ecd7dc0b2d51fd7c3faf49edbe662151e2 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 16 Jan 2014 13:54:03 +0100 Subject: [PATCH] webui: use unique ids for checkboxes Checkboxes have not used unique ids across the whole UI. It broke checking by clicking on label for later displayed instances. It became serious problem when rcue introduced new checkbox styles with 'label clicking' as default check method. https://fedorahosted.org/freeipa/ticket/3904 Reviewed-By: Adam Misnyovszki --- install/ui/src/freeipa/widget.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/install/ui/src/freeipa/widget.js b/install/ui/src/freeipa/widget.js index b3ea3a838..b642cee02 100644 --- a/install/ui/src/freeipa/widget.js +++ b/install/ui/src/freeipa/widget.js @@ -1199,10 +1199,7 @@ IPA.option_widget_base = function(spec, that) { that.get_input_name = function() { if (!that._input_name) { - var name = that.name; - if (that.input_type === 'radio') { - name = IPA.html_util.get_next_id(name); - } + var name = IPA.html_util.get_next_id(that.name); that._input_name = name; that._selector = 'input[name="'+name+'"]'; }