From 664ae51eb6e76ceb3630687d2ee423f69fb0ba19 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Fri, 19 Mar 2010 09:47:35 -0400 Subject: [PATCH] Raise an error if no modifications were performed in an update. This will alert the user that nothing was done and is handy when used with --attr=''. This can be used to delete a non-required attribute but can be set to any valid attribute, present or not. We should alert the user if they attempt to delete a non-existant value. --- ipalib/plugins/baseldap.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/ipalib/plugins/baseldap.py b/ipalib/plugins/baseldap.py index 6e6012532..13529e69f 100644 --- a/ipalib/plugins/baseldap.py +++ b/ipalib/plugins/baseldap.py @@ -311,8 +311,6 @@ class LDAPUpdate(LDAPQuery, crud.Update): ldap.update_entry(dn, entry_attrs) except errors.NotFound: self.obj.handle_not_found(*keys) - except errors.EmptyModlist: - pass try: (dn, entry_attrs) = ldap.get_entry(dn, attrs_list)