From 6c438fff337794ac168a9b8aa7269b9afff7c95f Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 12 May 2015 13:00:10 +0200 Subject: [PATCH] Server Upgrade: raise RuntimeError instead exit() Ldapupdater should not call sys.exit() in the middle of execution and should fail gracefully https://fedorahosted.org/freeipa/ticket/4904 Reviewed-By: David Kupka --- ipaserver/install/ldapupdate.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipaserver/install/ldapupdate.py b/ipaserver/install/ldapupdate.py index 2ea890efc..2f5bcc748 100644 --- a/ipaserver/install/ldapupdate.py +++ b/ipaserver/install/ldapupdate.py @@ -894,7 +894,7 @@ class LDAPUpdate: data = self.read_file(f) except Exception, e: self.error("error reading update file '%s'", f) - sys.exit(e) + raise RuntimeError(e) self.parse_update_file(f, data, all_updates) self._run_updates(all_updates)