IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Issue 9497 - update debug logging in ipa_otp_lasttoken

Browse Source 
Fixes: https://pagure.io/freeipa/issue/9497

Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Mark Reynolds 2023-12-12 08:40:13 -05:00 committed by Florence Blanc-Renaud
parent 2a1d454c74
commit 6cd5a0847a
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
daemons/ipa-slapi-plugins/ipa-otp-lasttoken/ipa_otp_lasttoken.c
View File

@ -33,7 +33,7 @@
* Authors: * Authors:
* Nathaniel McCallum <npmccallum@redhat.com> * Nathaniel McCallum <npmccallum@redhat.com>
* *
* Copyright (C) 2013 Red Hat, Inc. * Copyright (C) 2013-2023 Red Hat, Inc.
* All rights reserved. * All rights reserved.
* END COPYRIGHT BLOCK **/ * END COPYRIGHT BLOCK **/
@ -46,7 +46,7 @@
#include "util.h" #include "util.h"
#define PLUGIN_NAME "ipa-otp-lasttoken" #define IPA_PLUGIN_NAME "ipa-otp-lasttoken"
#define OTP_CONTAINER "cn=otp,%s" #define OTP_CONTAINER "cn=otp,%s"
static struct otp_config *otp_config; static struct otp_config *otp_config;
@ -191,9 +191,14 @@ static inline int send_error(Slapi_PBlock *pb, int rc, const char *errstr)
static int preop_del(Slapi_PBlock *pb) static int preop_del(Slapi_PBlock *pb)
{ {
char *dn = NULL;
if (is_allowed(pb, NULL)) if (is_allowed(pb, NULL))
return 0; return 0;
slapi_pblock_get(pb, SLAPI_TARGET_DN, &dn);
LOG("Can't delete last active token (%s)", dn);
return send_error(pb, LDAP_UNWILLING_TO_PERFORM, return send_error(pb, LDAP_UNWILLING_TO_PERFORM,
"Can't delete last active token"); "Can't delete last active token");
} }
@ -221,12 +226,14 @@ static int preop_mod(Slapi_PBlock *pb)
return 0; return 0;
/* If a protected attribute is modified, deny. */ /* If a protected attribute is modified, deny. */
for (int i = 0; mods != NULL && mods[i] != NULL; i++) { for (size_t i = 0; mods != NULL && mods[i] != NULL; i++) {
for (int j = 0; errors[j].attr != NULL; j++) { for (size_t j = 0; errors[j].attr != NULL; j++) {
if (strcasecmp(mods[i]->mod_type, errors[j].attr) == 0) if (strcasecmp(mods[i]->mod_type, errors[j].attr) == 0) {
LOG("%s (%s)", errors[j].msg, slapi_entry_get_dn_const(entry));
return send_error(pb, LDAP_UNWILLING_TO_PERFORM, errors[j].msg); return send_error(pb, LDAP_UNWILLING_TO_PERFORM, errors[j].msg);
} }
} }
}
return 0; return 0;
} }
@ -284,7 +291,7 @@ static int ipa_otp_lasttoken_start(Slapi_PBlock *pb)
int ipa_otp_lasttoken_init(Slapi_PBlock *pb) int ipa_otp_lasttoken_init(Slapi_PBlock *pb)
{ {
static const Slapi_PluginDesc preop_desc = { static const Slapi_PluginDesc preop_desc = {
PLUGIN_NAME, IPA_PLUGIN_NAME,
"FreeIPA", "FreeIPA",
"FreeIPA/1.0", "FreeIPA/1.0",
"Protect the user's last active token" "Protect the user's last active token"
@ -297,14 +304,14 @@ int ipa_otp_lasttoken_init(Slapi_PBlock *pb)
ret |= slapi_pblock_set(pb, SLAPI_PLUGIN_VERSION, SLAPI_PLUGIN_VERSION_01); ret |= slapi_pblock_set(pb, SLAPI_PLUGIN_VERSION, SLAPI_PLUGIN_VERSION_01);
ret |= slapi_pblock_set(pb, SLAPI_PLUGIN_DESCRIPTION, (void *) &preop_desc); ret |= slapi_pblock_set(pb, SLAPI_PLUGIN_DESCRIPTION, (void *) &preop_desc);
ret |= slapi_register_plugin("betxnpreoperation", 1, __func__, preop_init, ret |= slapi_register_plugin("betxnpreoperation", 1, __func__, preop_init,
PLUGIN_NAME " betxnpreoperation", NULL, IPA_PLUGIN_NAME " betxnpreoperation", NULL,
ipa_otp_lasttoken_plugin_id); ipa_otp_lasttoken_plugin_id);
ret |= slapi_register_plugin("postoperation", 1, __func__, postop_init, ret |= slapi_register_plugin("postoperation", 1, __func__, postop_init,
PLUGIN_NAME " postoperation", NULL, IPA_PLUGIN_NAME " postoperation", NULL,
ipa_otp_lasttoken_plugin_id); ipa_otp_lasttoken_plugin_id);
ret |= slapi_register_plugin("internalpostoperation", 1, __func__, ret |= slapi_register_plugin("internalpostoperation", 1, __func__,
intpostop_init, intpostop_init,
PLUGIN_NAME " internalpostoperation", NULL, IPA_PLUGIN_NAME " internalpostoperation", NULL,
ipa_otp_lasttoken_plugin_id); ipa_otp_lasttoken_plugin_id);
ret |= slapi_pblock_set(pb, SLAPI_PLUGIN_START_FN, ret |= slapi_pblock_set(pb, SLAPI_PLUGIN_START_FN,
(void *)ipa_otp_lasttoken_start); (void *)ipa_otp_lasttoken_start);