Turn verify_host_resolvable() into a wrapper around ipapython.dnsutil

The code was duplicate and less generic anyway.
As a side-effect I had to re-wrap dns.exception.DNSException into a
PublicError so it can be displayed to the user.

DNSError is now a super class for other DNS-related errors. Errors from
DNS resolver are re-raised as DNSResolverError.

https://fedorahosted.org/freeipa/ticket/5710

Reviewed-By: Martin Basti <mbasti@redhat.com>
This commit is contained in:
Petr Spacek
2016-05-17 17:28:36 +02:00
committed by Martin Basti
parent dc405005f5
commit 70794c7b1d
3 changed files with 72 additions and 61 deletions

View File

@@ -311,8 +311,7 @@ class TestCRUD(XMLRPC_test):
def test_try_add_not_in_dns(self, host):
host.ensure_missing()
command = host.make_create_command(force=False)
with raises_exact(errors.DNSNotARecordError(
reason=u'Host does not have corresponding DNS A/AAAA record')):
with raises_exact(errors.DNSNotARecordError(hostname=host)):
command()
def test_add_host_with_null_password(self, host):