mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2025-02-25 18:55:28 -06:00
Add the version option to all Commands
Several Commands were missing the 'version' option. Add it to those that were missing it. Do not remove the version option before calling commands. This means methods such as execute(), forward(), run() receive it. Several of these needed `**options` added to their signatures. Commands in the Cert plugin passed any unknown options to the underlying functions, these are changed to pass what's needed explicitly. Some commands in DNS and Batch plugins now pass version to commands they call. When the option is not given, fill it in automatically. (In a subsequent commit, a warning will be added in this case). Note that the public API did not change: all RPC calls already accepted a version option. There's no need for an API version bump (even though API.txt changes substantially). Design page: http://freeipa.org/page/V3/Messages Tickets: https://fedorahosted.org/freeipa/ticket/2732 https://fedorahosted.org/freeipa/ticket/3294
This commit is contained in:
committed by
Martin Kosek
parent
246bc3f3ea
commit
7336a176b4
@@ -97,7 +97,7 @@ class exhelloworld(Command):
|
||||
# This is where the command functionality should go.
|
||||
# It is always executed on the server-side, so don't rely
|
||||
# on client-side stuff in here!
|
||||
def execute(self, name):
|
||||
def execute(self, name, **options):
|
||||
return dict(summary='Hello world, %s!' % name)
|
||||
|
||||
# register the command, uncomment this line if you want to try it out
|
||||
|
||||
Reference in New Issue
Block a user