From 743828b0f47ca4934125cfb8dc57f79283b95a4d Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Fri, 6 May 2016 17:54:10 +0200 Subject: [PATCH] ipaplatform.redhat: Use bytestrings when calling rpm.so for version comparison Part of the work for: https://fedorahosted.org/freeipa/ticket/4985 Reviewed-By: Martin Basti --- ipaplatform/redhat/tasks.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ipaplatform/redhat/tasks.py b/ipaplatform/redhat/tasks.py index ace29bd1c..294a9fe1a 100644 --- a/ipaplatform/redhat/tasks.py +++ b/ipaplatform/redhat/tasks.py @@ -84,13 +84,17 @@ class IPAVersion(object): def __init__(self, version): self.version = version + @property + def _bytes(self): + return self.version.encode('utf-8') + def __eq__(self, other): assert isinstance(other, IPAVersion) - return _librpm.rpmvercmp(self.version, other.version) == 0 + return _librpm.rpmvercmp(self._bytes, other._bytes) == 0 def __lt__(self, other): assert isinstance(other, IPAVersion) - return _librpm.rpmvercmp(self.version, other.version) < 0 + return _librpm.rpmvercmp(self._bytes, other._bytes) < 0 class RedHatTaskNamespace(BaseTaskNamespace):