IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

DNS Locations: optimization: use server-find to get information

Browse Source 
Because separated calls for of server-show, getting server data is quite
slow. This commit replaces several server-show with one server-find
command. There are future plans to improve speed of server-find that
will be beneficial for DNS locations.

https://fedorahosted.org/freeipa/ticket/2008

Reviewed-By: Petr Spacek <pspacek@redhat.com>
This commit is contained in:
Martin Basti 2016-06-22 13:12:52 +02:00
parent 218734ba5a
commit 7bf3b1d546
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ipaserver/dns_data_management.py
View File

@ -78,8 +78,7 @@ class IPASystemRecords(object):
"""
self.__init_data()
def __get_server_attrs(self, hostname):
server_result = self.api_instance.Command.server_show(hostname)['result']
def __get_server_attrs(self, server_result):
weight = int(server_result.get('ipaserviceweight', [u'100'])[0])
location = server_result.get('ipalocation_location', [None])[0]
roles = set(server_result.get('enabled_role_servrole', ()))
@ -93,11 +92,10 @@ class IPASystemRecords(object):
self.servers_data = {}
servers_result = self.api_instance.Command.server_find(
pkey_only=True)['result']
servers = [s['cn'][0] for s in servers_result]
for s in servers:
no_members=False)['result']
for s in servers_result:
weight, location, roles = self.__get_server_attrs(s)
self.servers_data[s] = {
self.servers_data[s['cn'][0]] = {
'weight': weight,
'location': location,
'roles': roles,