Web UI: move ./_base/metadata_provider.js to ./metadata.js

Metadata provider is IPA specific object, not a framework object, so it should not be in _base directory.

https://fedorahosted.org/freeipa/ticket/3604

install/ui/src/freeipa/aci.js

@@ -20,7 +20,7 @@
  */
 
 define([
-    './_base/metadata_provider',
+    './metadata',
     './ipa',
     './jquery',
     './phases',

install/ui/src/freeipa/association.js

@@ -24,7 +24,7 @@
 
 define([
     'dojo/Deferred',
-    './_base/metadata_provider',
+    './metadata',
     './ipa',
     './jquery',
     './navigation',

install/ui/src/freeipa/automember.js

@@ -19,7 +19,7 @@
  */
 
 define([
-    './_base/metadata_provider',
+    './metadata',
     './ipa',
     './jquery',
     './navigation',

install/ui/src/freeipa/certificate.js

@@ -21,7 +21,7 @@
 
 define([
     'dojo/_base/lang',
-    './_base/metadata_provider',
+    './metadata',
     './ipa',
     './jquery',
     './menu',

install/ui/src/freeipa/entity.js

@@ -23,7 +23,7 @@
 
 define([
         'dojo/_base/lang',
-        './_base/metadata_provider',
+        './metadata',
         './_base/Singleton_registry',
         './builder',
         './ipa',

install/ui/src/freeipa/field.js

@@ -25,7 +25,7 @@
 define([
     'dojo/_base/array',
     'dojo/_base/lang',
-    './_base/metadata_provider',
+    './metadata',
     './builder',
     './ipa',
     './jquery',

install/ui/src/freeipa/hbactest.js

@@ -19,7 +19,7 @@
  */
 
 define([
-        './_base/metadata_provider',
+        './metadata',
         './ipa',
         './jquery',
         './navigation',

install/ui/src/freeipa/ipa.js

@@ -25,7 +25,7 @@
 define(['./jquery',
         './json2',
         './_base/i18n',
-        './_base/metadata_provider',
+        './metadata',
         './builder',
         './reg',
         './text'],

install/ui/src/freeipa/metadata.js

@@ -18,8 +18,11 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-define(['dojo/_base/lang', './Provider', './Search_provider'],
+define([
-       function(lang, Provider, Search_provider) {
+        'dojo/_base/lang',
+        './_base/Provider',
+        './_base/Search_provider'
+    ], function(lang, Provider, Search_provider) {
 
     var metadata = new Provider({
         code: '@m:'
@@ -29,7 +32,7 @@ define(['dojo/_base/lang', './Provider', './Search_provider'],
         source: metadata,
         path: 'objects'
     });
-    var commmads = new Provider({
+    var commands = new Provider({
         code: '@mc:',
         source: metadata,
         path: 'commands'
@@ -56,7 +59,7 @@ define(['dojo/_base/lang', './Provider', './Search_provider'],
         array_attr: 'name'
     });
 
-    metadata.providers.push(objects, commmads, object_param, cmd_arg, cmd_option);
+    metadata.providers.push(objects, commands, object_param, cmd_arg, cmd_option);
 
     return metadata;
 });

install/ui/src/freeipa/text.js

@@ -24,7 +24,7 @@
  * Serves for returning labels, titles, messages from various providers.
  * Other providers can extends functionality.
  */
-define(['./_base/Provider', './_base/i18n', './_base/metadata_provider'],
+define(['./_base/Provider', './_base/i18n', './metadata'],
        function(Provider, i18n, metadata) {
 
     var text = new Provider({

install/ui/test/aci_tests.js

@@ -19,7 +19,7 @@
  */
 
 define([
-        'freeipa/_base/metadata_provider',
+        'freeipa/metadata',
         'freeipa/aci',
         'freeipa/details',
         'freeipa/facet',

install/ui/test/details_tests.js

@@ -19,7 +19,7 @@
  */
 
 define([
-    'freeipa/_base/metadata_provider',
+    'freeipa/metadata',
     'freeipa/ipa',
     'freeipa/jquery',
     'freeipa/details',