From 8a4ad659362f0d2bc843ba32a059cdc6bfcecc24 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud Date: Sat, 11 Jun 2022 16:18:00 +0200 Subject: [PATCH] ipa-replica-install: nsds5replicaUpdateInProgress is a Boolean nsds5replicaUpdateInProgress is defined in LDAP schema as a boolean. Now that IPA API is able to properly map booleans to the python bool type, this attribute is not a string any more and comparisons can be done directly based on its real type. The code in ipa-replica-install was reading nsds5replicaUpdateInProgress and calling value.tolower() == 'true' but should now use value == True instead. Related: https://pagure.io/freeipa/issue/9171 Signed-off-by: Florence Blanc-Renaud Reviewed-By: Alexander Bokovoy --- ipaserver/install/replication.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py index 50368622b..16be3760c 100644 --- a/ipaserver/install/replication.py +++ b/ipaserver/install/replication.py @@ -1096,7 +1096,7 @@ class ReplicationManager: elif status.find("Total update succeeded") > -1: print("\nUpdate succeeded") done = True - elif inprogress.lower() == 'true': + elif inprogress: print("\nUpdate in progress yet not in progress") else: print("\n[%s] reports: Update failed! Status: [%s]"