108: Changed cmd.default() so that it now only return dictionary of values for which defaults were generated; updated unit tests

ipalib/public.py

@@ -183,16 +183,15 @@ class cmd(plugable.Plugin):
     def normalize(self, **kw):
         return dict(self.normalize_iter(kw))
 
-    def default(self, **kw):
+    def default_iter(self, kw):
-        d = {}
+        for option in self.options:
-        for opt in self.options:
+            if option.name not in kw:
-            if opt.name not in kw:
+                value = option.default(**kw)
-                value = opt.default(**kw)
                 if value is not None:
-                    d[opt.name] = value
+                    yield(option.name, value)
-        assert not set(kw).intersection(d)
+
-        kw.update(d)
+    def default(self, **kw):
-        return kw
+        return dict(self.default_iter(kw))
 
     def validate(self, **kw):
         for (key, value) in kw.items():
@@ -201,7 +200,7 @@ class cmd(plugable.Plugin):
 
     def __call__(self, **kw):
         kw = self.normalize(**kw)
-        kw = self.default(**kw)
+        kw.update(self.default(**kw))
         self.validate(**kw)
         self.execute(**kw)
 

ipalib/tests/test_public.py

@@ -241,14 +241,13 @@ class test_cmd(ClassChecker):
         fill = dict(
             default_from='the default',
         )
-        filled = dict(
+        default = dict(
             option0='the default',
             option1='the default',
-            default_from='the default',
         )
         sub = self.subcls()
-        assert sub.default(**no_fill) == no_fill
+        assert sub.default(**no_fill) == {}
-        assert sub.default(**fill) == filled
+        assert sub.default(**fill) == default
 
 
 def test_obj():