IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix unchecked return values in ipa-winsync

Browse Source 
https://fedorahosted.org/freeipa/ticket/4713

Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Jan Cholasta 2014-11-10 18:10:59 +00:00
parent c8bc6b8818
commit 8b13c30dc2
1 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c
View File

@ -905,9 +905,9 @@ ipa_winsync_config_refresh_domain(
if (!iwdc->realm_name) { if (!iwdc->realm_name) {
/* error - could not find the IPA config entry with the realm name */ /* error - could not find the IPA config entry with the realm name */
LOG_FATAL("Error: could not find the entry containing the realm name for " LOG_FATAL("Error: could not find the entry containing the realm name "
"ds subtree [%s] filter [%s] attr [%s]\n", "[%d] ds subtree [%s] filter [%s] attr [%s]\n",
slapi_sdn_get_dn(ds_subtree), realm_filter, realm_attr); ret, slapi_sdn_get_dn(ds_subtree), realm_filter, realm_attr);
goto out; goto out;
} }
@ -918,9 +918,9 @@ ipa_winsync_config_refresh_domain(
&new_user_objclasses, NULL); &new_user_objclasses, NULL);
if (!new_user_objclasses) { if (!new_user_objclasses) {
/* error - could not find the entry containing list of objectclasses */ /* error - could not find the entry containing list of objectclasses */
LOG_FATAL("Error: could not find the entry containing the new user objectclass list for " LOG_FATAL("Error: could not find the entry containing the new user objectclass list "
"ds subtree [%s] filter [%s] attr [%s]\n", "[%d] ds subtree [%s] filter [%s] attr [%s]\n",
slapi_sdn_get_dn(ds_subtree), new_entry_filter, new_user_oc_attr); ret, slapi_sdn_get_dn(ds_subtree), new_entry_filter, new_user_oc_attr);
goto out; goto out;
} }
@ -933,9 +933,9 @@ ipa_winsync_config_refresh_domain(
NULL, &iwdc->homedir_prefix); NULL, &iwdc->homedir_prefix);
if (!iwdc->homedir_prefix) { if (!iwdc->homedir_prefix) {
/* error - could not find the home dir prefix */ /* error - could not find the home dir prefix */
LOG_FATAL("Error: could not find the entry containing the home directory prefix for " LOG_FATAL("Error: could not find the entry containing the home directory prefix "
"ds subtree [%s] filter [%s] attr [%s]\n", "[%d] ds subtree [%s] filter [%s] attr [%s]\n",
slapi_sdn_get_dn(ds_subtree), new_entry_filter, homedir_prefix_attr); ret, slapi_sdn_get_dn(ds_subtree), new_entry_filter, homedir_prefix_attr);
goto out; goto out;
} }
@ -950,8 +950,8 @@ ipa_winsync_config_refresh_domain(
NULL, &iwdc->login_shell); NULL, &iwdc->login_shell);
if (!iwdc->login_shell) { if (!iwdc->login_shell) {
LOG("Warning: could not find the entry containing the login shell " LOG("Warning: could not find the entry containing the login shell "
"attribute for ds subtree [%s] filter [%s] attr [%s]\n", "attribute [%d] ds subtree [%s] filter [%s] attr [%s]\n",
slapi_sdn_get_dn(ds_subtree), new_entry_filter, ret, slapi_sdn_get_dn(ds_subtree), new_entry_filter,
login_shell_attr); login_shell_attr);
} }
} }
@ -969,9 +969,9 @@ ipa_winsync_config_refresh_domain(
NULL, &default_group_name); NULL, &default_group_name);
if (!default_group_name) { if (!default_group_name) {
/* error - could not find the default group name */ /* error - could not find the default group name */
LOG_FATAL("Error: could not find the entry containing the default group name for " LOG_FATAL("Error: could not find the entry containing the default group name "
"ds subtree [%s] filter [%s] attr [%s]\n", "[%d] ds subtree [%s] filter [%s] attr [%s]\n",
slapi_sdn_get_dn(ds_subtree), new_entry_filter, default_group_attr); ret, slapi_sdn_get_dn(ds_subtree), new_entry_filter, default_group_attr);
goto out; goto out;
} }
@ -1014,9 +1014,9 @@ ipa_winsync_config_refresh_domain(
NULL, &inactivated_group_dn); NULL, &inactivated_group_dn);
if (!inactivated_group_dn) { if (!inactivated_group_dn) {
/* error - could not find the inactivated group dn */ /* error - could not find the inactivated group dn */
LOG("Could not find the DN of the inactivated users group ds " LOG("Could not find the DN of the inactivated users group "
"subtree [%s] filter [%s]. Ignoring\n", "[%d] ds subtree [%s] filter [%s]. Ignoring\n",
slapi_sdn_get_dn(ds_subtree), inactivated_filter); ret, slapi_sdn_get_dn(ds_subtree), inactivated_filter);
goto out; goto out;
} }
} }
@ -1026,9 +1026,9 @@ ipa_winsync_config_refresh_domain(
NULL, &activated_group_dn); NULL, &activated_group_dn);
if (!activated_group_dn) { if (!activated_group_dn) {
/* error - could not find the activated group dn */ /* error - could not find the activated group dn */
LOG("Could not find the DN of the activated users group ds " LOG("Could not find the DN of the activated users group "
"subtree [%s] filter [%s]. Ignoring\n", "[%d] ds subtree [%s] filter [%s]. Ignoring\n",
slapi_sdn_get_dn(ds_subtree), activated_filter); ret, slapi_sdn_get_dn(ds_subtree), activated_filter);
goto out; goto out;
} }
} }