Add title to 'add' dialog for 'DNS' entity

To improve translation quality the title of 'Add' dialog should be
specified explicitly in the spec and should be an entire sentence.

Fixes: https://pagure.io/freeipa/issue/7707
Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
This commit is contained in:
Stanislav Levin 2018-09-21 11:45:28 +03:00 committed by Serhii Tsymbaliuk
parent bafa0d5f4a
commit 8dddc003bd
2 changed files with 9 additions and 6 deletions

View File

@ -290,6 +290,7 @@ return {
], ],
standard_association_facets: true, standard_association_facets: true,
adder_dialog: { adder_dialog: {
title: '@i18n:objects.dnszone.add',
height: 300, height: 300,
sections: [ sections: [
{ {
@ -436,6 +437,7 @@ return {
} }
], ],
adder_dialog: { adder_dialog: {
title: '@i18n:objects.dnsforwardzone.add',
sections: [ sections: [
{ {
name: 'name', name: 'name',
@ -1348,6 +1350,7 @@ return {
} }
], ],
adder_dialog: { adder_dialog: {
title: '@i18n:objects.dnsrecord.add',
$factory: IPA.dns.record_adder_dialog, $factory: IPA.dns.record_adder_dialog,
fields: [ fields: [
{ {
@ -2006,15 +2009,12 @@ IPA.dns.record_type_table_widget = function(spec) {
that.create_add_dialog = function() { that.create_add_dialog = function() {
var title = text.get('@i18n:dialogs.add_title');
var label = that.entity.metadata.label_singular;
var dialog_spec = { var dialog_spec = {
entity: that.entity, entity: that.entity,
fields: [], fields: [],
widgets: [], widgets: [],
retry: false, retry: false,
title: title.replace('${entity}', label) title: text.get('@i18n:objects.dnsrecord.add')
}; };
var dnstype = that.dnstype.toLowerCase(); var dnstype = that.dnstype.toLowerCase();

View File

@ -667,9 +667,11 @@ class i18n_messages(Command):
"updated_dns": _("System DNS records updated"), "updated_dns": _("System DNS records updated"),
}, },
"dnsforwardzone": { "dnsforwardzone": {
"add": _("Add DNS forward zone"),
"remove": _("Remove DNS forward zones"), "remove": _("Remove DNS forward zones"),
}, },
"dnsrecord": { "dnsrecord": {
"add": _("Add DNS resource record"),
"data": _("Data"), "data": _("Data"),
"deleted_no_data": _("DNS record was deleted because it contained no data."), "deleted_no_data": _("DNS record was deleted because it contained no data."),
"other": _("Other Record Types"), "other": _("Other Record Types"),
@ -691,9 +693,10 @@ class i18n_messages(Command):
"type": _("Record Type"), "type": _("Record Type"),
}, },
"dnszone": { "dnszone": {
"identity": _("DNS Zone Settings"), "add": _("Add DNS zone"),
"add_permission":_("Add Permission"), "add_permission": _("Add permission"),
"add_permission_confirm":_("Are you sure you want to add permission for DNS Zone ${object}?"), "add_permission_confirm":_("Are you sure you want to add permission for DNS Zone ${object}?"),
"identity": _("DNS Zone Settings"),
"remove": _("Remove DNS zones"), "remove": _("Remove DNS zones"),
"remove_permission": _("Remove Permission"), "remove_permission": _("Remove Permission"),
"remove_permission_confirm": _("Are you sure you want to remove permission for DNS Zone ${object}?"), "remove_permission_confirm": _("Are you sure you want to remove permission for DNS Zone ${object}?"),