IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix incorrect suffix handling in topology checks

Browse Source 
When trying to delete a partially removed master entry lacking
'iparepltopomanagedsuffix' attribute, the code that tries to retrieve
tha value for further computations passes None and causes unhandled
internal errors.

If the attribute is empty or not present, we should return empty list
instead as to not break calling cod attribute, the code that tries to
retrieve tha value for further computations passes None and causes
unhandled internal errors. We should return empty list instead.

https://pagure.io/freeipa/issue/6965

Reviewed-By: Felipe Volpone <felipevolpone@gmail.com>
This commit is contained in:
Martin Babinsky 2017-05-26 12:23:51 +02:00
parent e8a7e2e38a
commit 8ef4888af7
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ipaserver/topology.py
View File

@ -72,12 +72,15 @@ def get_topology_connection_errors(graph):
def map_masters_to_suffixes(masters):
masters_to_suffix = {}
managed_suffix_attr = 'iparepltopomanagedsuffix_topologysuffix'
for master in masters:
try:
managed_suffixes = master.get(
'iparepltopomanagedsuffix_topologysuffix')
except KeyError:
if managed_suffix_attr not in master:
continue
managed_suffixes = master[managed_suffix_attr]
if managed_suffixes is None:
continue
for suffix_name in managed_suffixes: