No longer shell escape the DM password when calling pkisilent.

pkisilent was modified to handle escaping characters itself in
BZ https://bugzilla.redhat.com/show_bug.cgi?id=769388

This removes the workaround from ticket 1636.

https://fedorahosted.org/freeipa/ticket/2529

freeipa.spec.in

@@ -129,23 +129,15 @@ Requires: selinux-policy >= 3.9.7-27
 %endif
 Requires(post): selinux-policy-base
 Requires: slapi-nis >= 0.21
-%if 0%{?fedora} >= 16
-Requires: pki-ca >= 9.0.15
-Requires: pki-silent >= 9.0.15
-# Only tomcat6 greater than this version provides proper systemd support
-Requires: tomcat6 >= 6.0.32-17
-%else
-%if 0%{?fedora} >= 15
-Requires: pki-ca >= 9.0.15
-Requires: pki-silent >= 9.0.15
-Requires: pki-setup  >= 9.0.15
-%else
-Requires: pki-ca >= 9.0.5
-Requires: pki-silent >= 9.0.5
-%endif
-%endif
+Requires: pki-ca >= 9.0.18
+Requires: pki-silent >= 9.0.18
+Requires: pki-setup  >= 9.0.18
 Requires: dogtag-pki-common-theme
 Requires: dogtag-pki-ca-theme
+%if 0%{?fedora} >= 16
+# Only tomcat6 greater than this version provides proper systemd support
+Requires: tomcat6 >= 6.0.32-17
+%endif
 %if 0%{?rhel}
 Requires: subscription-manager
 %endif

ipaserver/install/cainstance.py

@@ -660,9 +660,6 @@ class CAInstance(service.Service):
                 args.append("-clone")
                 args.append("false")
 
-            # pkisilent does not escape the arguments before passing them to shell
-            args[2:] = [ipautil.shell_quote(i) for i in args[2:]]
-
             # Define the things we don't want logged
             nolog = (self.admin_password, self.dm_password,)