IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2024-12-24 16:10:02 -06:00
Code Issues Packages Projects Releases Wiki Activity

Do not check for DNA magic values

Browse Source 
The DNA magic value can be arbitrarily changed by admins so we cannot use a
const value to check. And we relly do not need to check at all. If the DNA
plugin is broken and leaves magic values to reach the post-op stage we have
bigger problems. So just simply get rid of this check.
This commit is contained in:
Simo Sorce 2012-07-26 14:30:39 -04:00
parent cc466e98ff
commit 9d853483fe
2 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen.h
View File

@ -54,8 +54,6 @@
#define IPANT_USER_ATTRS "ipantuserattrs"
#define IPANT_GROUP_ATTRS "ipantgroupattrs"
#define IPA_DNA_MAGIC 999
#define IPA_PLUGIN_NAME "ipa-sidgen-postop"
#define IPA_SIDGEN_FEATURE_DESC "IPA SIDGEN postop plugin"
#define IPA_SIDGEN_PLUGIN_DESC "Add a SID to newly added or modified " \

6
daemons/ipa-slapi-plugins/ipa-sidgen/ipa_sidgen_common.c
View File

@ -479,12 +479,6 @@ int find_sid_for_ldap_entry(struct slapi_entry *entry,
goto done;
}
if (uid_number == IPA_DNA_MAGIC || gid_number == IPA_DNA_MAGIC) {
LOG_FATAL("Looks that DNA plugin was not run before.\n");
ret = LDAP_OPERATIONS_ERROR;
goto done;
}
if (uid_number >= UINT32_MAX || gid_number >= UINT32_MAX) {
LOG_FATAL("ID value too large.\n");
ret = LDAP_CONSTRAINT_VIOLATION;