From 9f48c396497bd3e07045838d23afbb0d051dc136 Mon Sep 17 00:00:00 2001
From: David Kupka <dkupka@redhat.com>
Date: Thu, 9 Jun 2016 07:58:32 +0200
Subject: [PATCH] installer: index() raises ValueError

Expecting IndexError instead of ValueError led to traceback instead of correctly
reporting the error situation.

https://fedorahosted.org/freeipa/ticket/5945

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
---
 ipapython/install/cli.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipapython/install/cli.py b/ipapython/install/cli.py
index aed0bc9fe..9cd9ec768 100644
--- a/ipapython/install/cli.py
+++ b/ipapython/install/cli.py
@@ -299,9 +299,9 @@ class ConfigureTool(admintool.AdminTool):
             knob_cls = knob_classes[e.name]
             try:
                 if self.positional_arguments is None:
-                    raise IndexError
+                    raise ValueError
                 index = self.positional_arguments.index(e.name)
-            except IndexError:
+            except ValueError:
                 cli_name = knob_cls.cli_name or e.name.replace('_', '-')
                 desc = "option --{0}".format(cli_name)
             else: