IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Enable pylint unused-format-string-key check

Browse Source 
Enables check and fixes:
ipatests/test_xmlrpc/test_permission_plugin.py:534:
[W1301(unused-format-string-key), test_permission] Unused key 'tdn' in
format string dictionary)
ipatests/test_xmlrpc/test_permission_plugin.py:652:
[W1301(unused-format-string-key), test_permission] Unused key 'tdn' in
format string dictionary)

Reviewed-By: Jan Cholasta <jcholast@redhat.com>
This commit is contained in:
Martin Basti 2015-12-17 00:17:09 +01:00 committed by Jan Cholasta
parent 81ff72b9af
commit 9f49246476
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ipatests/test_xmlrpc/test_permission_plugin.py
View File

@ -533,8 +533,7 @@ class test_permission(Declarative):
'(targetfilter = "(objectclass=posixaccount)")' + '(targetfilter = "(objectclass=posixaccount)")' +
'(version 3.0;acl "permission:%(name)s";' '(version 3.0;acl "permission:%(name)s";'
'allow (write) groupdn = "ldap:///%(pdn)s";)' % 'allow (write) groupdn = "ldap:///%(pdn)s";)' %
{'tdn': DN(('uid', '*'), users_dn), {'name': permission1,
'name': permission1,
'pdn': permission1_dn}], 'pdn': permission1_dn}],
}, },
), ),
@ -651,8 +650,7 @@ class test_permission(Declarative):
'(targetfilter = "(objectclass=posixaccount)")' + '(targetfilter = "(objectclass=posixaccount)")' +
'(version 3.0;acl "permission:%(name)s";' '(version 3.0;acl "permission:%(name)s";'
'allow (write) groupdn = "ldap:///%(pdn)s";)' % 'allow (write) groupdn = "ldap:///%(pdn)s";)' %
{'tdn': DN(('uid', '*'), users_dn), {'name': permission1,
'name': permission1,
'pdn': permission1_dn}], 'pdn': permission1_dn}],
}, },
], ],

1
make-lint
View File

@ -279,7 +279,6 @@ def main():
linter.set_option('disable', 'unnecessary-pass') linter.set_option('disable', 'unnecessary-pass')
linter.set_option('disable', 'unnecessary-semicolon') linter.set_option('disable', 'unnecessary-semicolon')
linter.set_option('disable', 'unused-argument') linter.set_option('disable', 'unused-argument')
linter.set_option('disable', 'unused-format-string-key')
linter.set_option('disable', 'unused-variable') linter.set_option('disable', 'unused-variable')
linter.set_option('disable', 'useless-else-on-loop') linter.set_option('disable', 'useless-else-on-loop')
linter.set_option('disable', 'unbalanced-tuple-unpacking') linter.set_option('disable', 'unbalanced-tuple-unpacking')