IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

webui: optimize (re)creation of option widget

Browse Source 
There is a case where attributes widget can contain > 1000 items.
It's about 3000 nodes. It's slow in jQuery. Simple move to dojo
speeds it up (is closer to native calls) while maintaining developer
friendliness.

Now the biggest lag is in browser's render. It's probably not worth
developer time to optimize that.

https://fedorahosted.org/freeipa/ticket/4253

Reviewed-By: Endi Sukma Dewata <edewata@redhat.com>
This commit is contained in:
Petr Vobornik 2014-07-09 14:00:54 +02:00
parent 740d42257f
commit 9fa447cb6e
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
install/ui/src/freeipa/widget.js
View File

@ -24,6 +24,7 @@
define(['dojo/_base/array',
'dojo/_base/lang',
'dojo/dom-construct',
'dojo/Evented',
'dojo/has',
'dojo/keys',
@ -43,7 +44,7 @@ define(['dojo/_base/array',
'./util',
'exports'
],
function(array, lang, Evented, has, keys, on, string, topic, builder,
function(array, lang, construct, Evented, has, keys, on, string, topic, builder,
datetime, entity_mod, IPA, $, navigation, phases, reg, rpc, text, util, exp) {
/**
@ -1379,16 +1380,17 @@ IPA.option_widget_base = function(spec, that) {
};
that.create_options = function(container) {
for (var i=0; i<that.options.length; i++) {
container = $(container)[0];
for (var i=0, l=that.options.length; i<l; i++) {
var option_container = that.create_option_container();
var option = that.options[i];
that.create_option(option, option_container);
option_container.appendTo(container);
construct.place(option_container, container);
}
};
that.create_option_container = function() {
return $('<li/>');
return construct.create('li');
};
that._create_option = function(option, container) {
@ -1396,11 +1398,11 @@ IPA.option_widget_base = function(spec, that) {
var id = that._option_next_id + input_name;
var enabled = that.enabled && option.enabled;
var opt_cont = $('<span/>', {
var opt_cont = construct.create('span', {
"class": that.intput_type + '-cnt'
}).appendTo(container);
});
option.input_node = $('<input/>', {
option.input_node = construct.create('input', {
id: id,
type: that.input_type,
name: input_name,
@ -1408,15 +1410,16 @@ IPA.option_widget_base = function(spec, that) {
value: option.value,
title: option.tooltip || that.tooltip,
change: that.on_input_change
}).appendTo(opt_cont);
}, opt_cont);
option.label_node = $('<label/>', {
html: option.label || '',
option.label_node = construct.create('label', {
title: option.tooltip || that.tooltip,
'for': id
}).appendTo(opt_cont);
}, opt_cont);
option.label_node.textContent = option.label || '';
that.new_option_id();
construct.place(opt_cont, container);
};
that.create_option = function(option, container) {