From a71729cc01b83916b5e362a38ce3d65e129b1815 Mon Sep 17 00:00:00 2001 From: Thierry Bordaz Date: Tue, 24 Jul 2018 12:16:35 +0200 Subject: [PATCH] In IPA 4.4 when updating userpassword with ldapmodify does not update krbPasswordExpiration nor krbLastPwdChange When making ipa-pwd-extop TXN aware, some callbacks are call twice. Particularily ipapwd_pre_add is called during PRE_ADD and TXN_PRE_ADD ipapwd_pre_mod is called during PRE_MOD and TXN_PRE_MOD ipapwd_post_modadd is called during POST_ADD and TXN_POST_ADD ipapwd_post_modadd is called during POST_MOD and TXN_POST_MOD It is not the expected behavior and it results on some skipped updates krbPasswordExpiration and krbLastPwdChange https://pagure.io/freeipa/issue/7601 Reviewed-By: Florence Blanc-Renaud --- daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c index c62eae334..209d59625 100644 --- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c +++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/prepost.c @@ -1488,8 +1488,6 @@ int ipapwd_pre_init(Slapi_PBlock *pb) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_VERSION, SLAPI_PLUGIN_VERSION_01); if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_DESCRIPTION, (void *)&ipapwd_plugin_desc); if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_PRE_BIND_FN, (void *)ipapwd_pre_bind); - if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_PRE_ADD_FN, (void *)ipapwd_pre_add); - if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_PRE_MODIFY_FN, (void *)ipapwd_pre_mod); return ret; } @@ -1513,9 +1511,7 @@ int ipapwd_post_init(Slapi_PBlock *pb) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_VERSION, SLAPI_PLUGIN_VERSION_01); if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_DESCRIPTION, (void *)&ipapwd_plugin_desc); - if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_POST_ADD_FN, (void *)ipapwd_post_modadd); if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_POST_DELETE_FN, (void *)ipapwd_post_updatecfg); - if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_POST_MODIFY_FN, (void *)ipapwd_post_modadd); if (!ret) ret = slapi_pblock_set(pb, SLAPI_PLUGIN_POST_MODRDN_FN, (void *)ipapwd_post_updatecfg); return ret;