IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-01-11 08:41:55 -06:00
Code Issues Packages Projects Releases Wiki Activity

ipatests: use wait_for_replication for hidden replica checks

Browse Source 
Previously, hidden replica checks were run without waiting for replication
to complete, potentially leading to unstable behavior.
Use wait_for_replication.

Fixes: https://pagure.io/freeipa/issue/8534
Signed-off-by: François Cami <fcami@redhat.com>
Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Mohammad Rizwan Yusuf <myusuf@redhat.com>
This commit is contained in:
François Cami 2021-03-04 10:15:35 +01:00 committed by Florence Blanc-Renaud
parent d5ee7528b2
commit acf31d043f
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ipatests/test_integration/test_replica_promotion.py
View File

@ -951,8 +951,11 @@ class TestHiddenReplicaPromotion(IntegrationTest):
self.replicas[0].hostname, '--state=enabled'
])
self._check_server_role(self.replicas[0], 'enabled')
self._check_dnsrecords([self.master, self.replicas[0]])
tasks.wait_for_replication(
self.replicas[0].ldap_connect()
)
self._check_config([self.master, self.replicas[0]])
self._check_dnsrecords([self.master, self.replicas[0]])
result = self.replicas[0].run_command([
'ipa', 'server-state',
@ -967,6 +970,10 @@ class TestHiddenReplicaPromotion(IntegrationTest):
self.replicas[0].hostname, '--state=hidden'
])
self._check_server_role(self.replicas[0], 'hidden')
tasks.wait_for_replication(
self.replicas[0].ldap_connect()
)
self._check_config([self.master], [self.replicas[0]])
self._check_dnsrecords([self.master], [self.replicas[0]])
def test_replica_from_hidden(self):
@ -1030,14 +1037,11 @@ class TestHiddenReplicaPromotion(IntegrationTest):
stdin_text=dirman_password + '\nyes'
)
# wait for the replica to be available
tasks.wait_for_ipa_to_start(self.replicas[0])
# give replication some time
time.sleep(5)
tasks.kinit_admin(self.master)
tasks.kinit_admin(self.replicas[0])
# FIXME: restore turns hidden replica into enabled replica
# restore turns a hidden replica into an enabled replica
# https://pagure.io/freeipa/issue/7894
self._check_config([self.master, self.replicas[0]])
self._check_server_role(self.replicas[0], 'enabled')