IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

rpcserver: fix crash in XML-RPC system commands

Browse Source 
Fix an AttributeError in XML-RPC methodSignature and methodHelp commands
caused by incorrect mangled name usage.

https://fedorahosted.org/freeipa/ticket/6217

Reviewed-By: Lenka Doudova <ldoudova@redhat.com>
Reviewed-By: David Kupka <dkupka@redhat.com>
This commit is contained in:
Jan Cholasta
2016-09-01 09:59:37 +02:00
committed by David Kupka
parent 17ea4ae6b9
commit afcb3bd3c3
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ipaserver/rpcserver.py
View File

@@ -311,7 +311,7 @@ class WSGIExecutioner(Executioner):
if 'wsgi_dispatch' in self.api.Backend: if 'wsgi_dispatch' in self.api.Backend:
self.api.Backend.wsgi_dispatch.mount(self, self.key) self.api.Backend.wsgi_dispatch.mount(self, self.key)
def __get_command(self, name): def _get_command(self, name):
try: try:
# assume version 1 for unversioned command calls # assume version 1 for unversioned command calls
command = self.api.Command[name, '1'] command = self.api.Command[name, '1']
@@ -362,7 +362,7 @@ class WSGIExecutioner(Executioner):
if name in self._system_commands: if name in self._system_commands:
result = self._system_commands[name](self, *args, **options) result = self._system_commands[name](self, *args, **options)
else: else:
command = self.__get_command(name) command = self._get_command(name)
result = command(*args, **options) result = command(*args, **options)
except PublicError as e: except PublicError as e:
if self.api.env.debug: if self.api.env.debug:
@@ -713,7 +713,7 @@ class xmlserver(KerberosWSGIExecutioner):
# for now let's not go out of our way to document standard XML-RPC # for now let's not go out of our way to document standard XML-RPC
return u'undef' return u'undef'
else: else:
self.__get_command(method_name) self._get_command(method_name)
# All IPA commands return a dict (struct), # All IPA commands return a dict (struct),
# and take a params, options - list and dict (array, struct) # and take a params, options - list and dict (array, struct)
@@ -725,7 +725,7 @@ class xmlserver(KerberosWSGIExecutioner):
if method_name in self._system_commands: if method_name in self._system_commands:
return u'' return u''
else: else:
command = self.__get_command(method_name) command = self._get_command(method_name)
return unicode(command.doc or '') return unicode(command.doc or '')
_system_commands = { _system_commands = {