IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2024-12-23 15:40:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

dns: allow PTR records in arbitrary zones

Browse Source 
PTR records in zones other than in-addr.arpa and in6.arpa are legal,
e.g. DNS-SD [RFC6763] uses such records.  If in a reverse zone
proceed with the existing checks, otherwise just accept the record.

Fixes: https://pagure.io/freeipa/issue/5566
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Fraser Tweedale 2020-11-09 15:22:34 +11:00 committed by Alexander Bokovoy
parent 5915031830
commit b153b23c75
2 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ipaserver/plugins/dns.py
View File

@ -3111,10 +3111,11 @@ class dnsrecord(LDAPObject):
zone_len = REVERSE_DNS_ZONES[valid_zone]
if not zone_len:
allowed_zones = ', '.join([unicode(revzone) for revzone in
REVERSE_DNS_ZONES])
raise errors.ValidationError(name='ptrrecord',
error=unicode(_('Reverse zone for PTR record should be a sub-zone of one the following fully qualified domains: %s') % allowed_zones))
# PTR records in zones other than in-addr.arpa and ip6.arpa are
# legal, e.g. DNS-SD [RFC6763] uses such records. If we have
# such a record there's nothing more to do. Otherwise continue
# with the ip4/ip6 reverse zone checks below.
return
addr_len = len(addr.labels)

18
ipatests/test_xmlrpc/test_dns_plugin.py
View File

@ -3331,6 +3331,24 @@ class test_dns(Declarative):
},
),
dict(
desc='Add PTR record in a non-.arpa zone [DNS-SD]',
command=(
'dnsrecord_add',
[zone1, '_http._tcp'],
{'ptrrecord': 'home._http._tcp'},
),
expected={
'value': DNSName('_http._tcp'),
'summary': None,
'result': {
'dn': DN(('idnsname', '_http._tcp'), zone1_dn),
'idnsname': [DNSName('_http._tcp')],
'ptrrecord': ['home._http._tcp'],
'objectclass': objectclasses.dnsrecord,
},
},
),
dict(
desc='Delete zone %r' % zone1,